Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 17911007: Have DispatchToMethod use base::internal::UnwrapTraits when dispatching (Closed)

Created:
7 years, 6 months ago by Ryan Sleevi
Modified:
7 years, 5 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Have DispatchToMethod use base::internal::UnwrapTraits when dispatching When dispatching, have base::DispatchToMethod/DispatchToFunction use the base::internal::UnwrapTraits<> to properly unwrap the base::Tuple's wrapped argument. This ensures that methods that expect a "T*" can be properly dispatched when the tuple contains a scoped_refptr<T> without relying on implicit conversions. BUG=110610 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208903

Patch Set 1 : Retry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -60 lines) Patch
M base/tuple.h View 36 chunks +300 lines, -60 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ryan Sleevi
darin: Hopefully an easy stamp. This was discussed with ajwong@ as a reasonable path forward.
7 years, 6 months ago (2013-06-26 22:10:56 UTC) #1
darin (slow to review)
LGTM
7 years, 6 months ago (2013-06-26 22:45:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/17911007/2002
7 years, 6 months ago (2013-06-26 23:01:22 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-06-27 12:48:03 UTC) #4
Message was sent while issue was closed.
Change committed as 208903

Powered by Google App Engine
This is Rietveld 408576698