Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 17894007: Update includes and delete remaining strings forwarding headers. (Closed)

Created:
7 years, 5 months ago by Avi (use Gerrit)
Modified:
7 years, 5 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, jam, jshin+watch_chromium.org
Visibility:
Public.

Description

Update includes and delete remaining strings forwarding headers. BUG=247723 TEST=everything compiles OK TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208900

Patch Set 1 #

Patch Set 2 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -21 lines) Patch
D base/string_util.h View 1 chunk +0 lines, -7 lines 0 comments Download
D base/stringprintf.h View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/component_updater/component_patcher_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/test/component_updater_service_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/test/component_updater_service_unittest_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/page_state_serialization_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/gaia_oauth_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/native_client/src/trusted/plugin/nacl_http_response_headers.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/17894007/1
7 years, 5 months ago (2013-06-26 21:34:42 UTC) #1
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 5 months ago (2013-06-26 21:40:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/17894007/1
7 years, 5 months ago (2013-06-26 21:42:07 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-06-26 21:58:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/17894007/5002
7 years, 5 months ago (2013-06-26 22:07:55 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-06-27 12:38:26 UTC) #6
Message was sent while issue was closed.
Change committed as 208900

Powered by Google App Engine
This is Rietveld 408576698