Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 17891002: cc: Reset tile priority before deleting tiling. (Closed)

Created:
7 years, 6 months ago by reveman
Modified:
7 years, 6 months ago
Reviewers:
vmpstr, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

cc: Reset tile priority before deleting tiling. BUG=251938 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208880

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add PictureLayerTilingClient::DestroyTile #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M cc/layers/picture_layer_impl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M cc/resources/picture_layer_tiling.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M cc/resources/picture_layer_tiling.cc View 1 2 3 chunks +5 lines, -0 lines 0 comments Download
M cc/test/fake_picture_layer_tiling_client.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
reveman
Please take a look. There's probably more cases where we need to reset the tile ...
7 years, 6 months ago (2013-06-26 14:21:32 UTC) #1
enne (OOO)
On 2013/06/26 14:21:32, David Reveman wrote: > Please take a look. There's probably more cases ...
7 years, 6 months ago (2013-06-26 15:39:27 UTC) #2
vmpstr
On 2013/06/26 15:39:27, enne wrote: > On 2013/06/26 14:21:32, David Reveman wrote: > > Please ...
7 years, 6 months ago (2013-06-26 17:16:28 UTC) #3
reveman
Added a DestroyTile client function to latest patch. PTAL. Long term I think we can ...
7 years, 6 months ago (2013-06-26 17:55:45 UTC) #4
enne (OOO)
Do you think it'd be worth DCHECKing in ~Tile to make sure the priority was ...
7 years, 6 months ago (2013-06-26 17:58:30 UTC) #5
enne (OOO)
Actually, ignore that thought. This issue is about the TileManager holding onto refs, so neither ...
7 years, 6 months ago (2013-06-26 18:04:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/17891002/6001
7 years, 6 months ago (2013-06-26 19:53:48 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=20714
7 years, 6 months ago (2013-06-26 20:18:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/17891002/24002
7 years, 6 months ago (2013-06-26 21:12:17 UTC) #9
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-06-26 21:23:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/17891002/24002
7 years, 6 months ago (2013-06-27 09:01:16 UTC) #11
commit-bot: I haz the power
7 years, 6 months ago (2013-06-27 09:55:36 UTC) #12
Message was sent while issue was closed.
Change committed as 208880

Powered by Google App Engine
This is Rietveld 408576698