Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8129)

Unified Diff: chrome/renderer/resources/extensions/web_view.js

Issue 17846010: <webview>: Move contentload event from content to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@guestview_loadstop
Patch Set: Merge with ToT Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/web_view.js
diff --git a/chrome/renderer/resources/extensions/web_view.js b/chrome/renderer/resources/extensions/web_view.js
index 0b2ad3784837bb62ff0e36f6212b8bcac0368306..d72cdbdde35a330fa5a8e962ccdb3743fb9b7c83 100644
--- a/chrome/renderer/resources/extensions/web_view.js
+++ b/chrome/renderer/resources/extensions/web_view.js
@@ -44,6 +44,7 @@ var createEvent = function(name) {
return new eventBindings.Event(name, undefined, eventOpts);
};
+var contentLoadEvent = createEvent('webview.onContentLoad');
var loadCommitEvent = createEvent('webview.onLoadCommit');
var loadStopEvent = createEvent('webview.onLoadStop');
@@ -309,6 +310,15 @@ WebView.prototype.setupWebviewNodeEvents_ = function() {
// TODO(fsamuel): Generalize this further as we add more events.
var onAttached = function(e) {
var detail = e.detail ? JSON.parse(e.detail) : {};
+ contentLoadEvent.addListener(function(event) {
lazyboy 2013/06/28 18:55:08 We now see a pattern here, so foo_events = { 'co
Fady Samuel 2013/06/28 21:24:35 Done.
+ var webviewEvent = new Event('contentload', {bubbles: true});
+ var attribs = WEB_VIEW_EVENTS['contentload'];
+ $Array.forEach(attribs, function(attribName) {
+ webviewEvent[attribName] = event[attribName];
+ });
+ webviewNode.dispatchEvent(webviewEvent);
+ }, {instanceId: detail.windowId});
+
loadCommitEvent.addListener(function(event) {
var webviewEvent = new Event('loadcommit', {bubbles: true});
var attribs = WEB_VIEW_EVENTS['loadcommit'];

Powered by Google App Engine
This is Rietveld 408576698