Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: components/dom_distiller/core/task_tracker.h

Issue 178303004: Add incremental updates for multipage distillation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix compile by adding a header. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/dom_distiller/core/task_tracker.h
diff --git a/components/dom_distiller/core/task_tracker.h b/components/dom_distiller/core/task_tracker.h
index c4098fe8a537e4c580928286153b8c4784629f4f..1f7a353889063a03e7753768dd07b1ae3794645b 100644
--- a/components/dom_distiller/core/task_tracker.h
+++ b/components/dom_distiller/core/task_tracker.h
@@ -11,6 +11,7 @@
#include "base/bind.h"
#include "base/callback.h"
#include "base/memory/weak_ptr.h"
+#include "components/dom_distiller/core/article_distillation_update.h"
#include "components/dom_distiller/core/article_entry.h"
#include "components/dom_distiller/core/distiller.h"
#include "components/dom_distiller/core/proto/distilled_page.pb.h"
@@ -45,6 +46,9 @@ class ViewRequestDelegate {
// when the corresponding ViewerHandle is destroyed (or when the
// DomDistillerService is destroyed).
virtual void OnArticleReady(const DistilledArticleProto* article_proto) = 0;
+
+ // Called when an article that is currently under distillation is updated.
cjhopman 2014/02/28 02:38:15 Hm, this comment is confusing... does that mean th
+ virtual void OnArticleUpdated(ArticleDistillationUpdate article_update) = 0;
cjhopman 2014/02/28 02:38:15 this should be taking a const& to the ArticleDisti
shashi 2014/03/02 02:53:40 We are copying updates since they contain pages wh
};
// A TaskTracker manages the various tasks related to viewing, saving,
@@ -91,8 +95,10 @@ class TaskTracker {
bool HasUrl(const GURL& url) const;
private:
- void OnDistilledDataReady(
+ void OnDistilledArticleReady(
scoped_ptr<DistilledArticleProto> distilled_article);
+ void OnArticleDistillationUpdated(
+ const ArticleDistillationUpdate& article_update);
// Posts a task to run DoSaveCallbacks with |distillation_succeeded|.
void ScheduleSaveCallbacks(bool distillation_succeeded);

Powered by Google App Engine
This is Rietveld 408576698