Reset page scale factor to 1.0f on new page navigation.

Reset page scale factor to 1.0f on new page navigation.

BUG=162482
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208942

[wjmaclean, 2013-06-26 13:17:35]

This is the revised CL after https://codereview.chromium.org/14643011/ was
closed dur to the refactoring.

Do we need to restrict the reset to non-Android builds?

[aelias_OOO_until_Jul13, 2013-06-26 17:27:40]

This override is permanent (the initial page scale will be set to the value of
initialPageScaleFactorOverride on each navigation by logic on the Blink side),
so you only need to call this once.

Yes, it should not apply to Android.  I suggest adding the call in
RenderViewImpl::ProcessViewLayoutFlags() behind if (!enable_viewport).

[wjmaclean, 2013-06-26 17:54:22]

On 2013/06/26 17:27:40, aelias wrote:
> This override is permanent (the initial page scale will be set to the value of
> initialPageScaleFactorOverride on each navigation by logic on the Blink side),
> so you only need to call this once.
> 
> Yes, it should not apply to Android.  I suggest adding the call in
> RenderViewImpl::ProcessViewLayoutFlags() behind if (!enable_viewport).

Done.

PTAL?

[aelias_OOO_until_Jul13, 2013-06-27 00:14:59]

lgtm

https://codereview.chromium.org/17830003/diff/4001/content/renderer/render_vi...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/17830003/diff/4001/content/renderer/render_vi...
content/renderer/render_view_impl.cc:3540:
webview()->setPageScaleFactorLimits(1, maxPageScaleFactor);
nit: move the call here as the two calls are related.

[jamesr, 2013-06-27 00:15:41]

lgtm2

[commit-bot: I haz the power, 2013-06-27 12:56:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/17830003/4001

[commit-bot: I haz the power, 2013-06-27 16:47:44]

Change committed as 208942

[Stephen White, 2013-06-27 17:19:26]

On 2013/06/27 16:47:44, I haz the power (commit-bot) wrote:
> Change committed as 208942

This seems to be breaking ~8 layout tests on Linux (so far):

Regressions: Unexpected image and text failures (3)
  fast/frames/frame-set-rotation-hit.html [ Failure ]
  fast/frames/frame-set-scaling-hit.html [ Failure ]
  scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html [ Failure ]

Regressions: Unexpected image-only failures (3)
  compositing/gestures/gesture-tapHighlight-simple-scaled-document.html [
ImageOnlyFailure ]
  fast/repaint/fixed-in-page-scale.html [ ImageOnlyFailure ]
  fast/repaint/fixed-right-in-page-scale.html [ ImageOnlyFailure ]

Regressions: Unexpected text-only failures (2)
  fast/events/touch/gesture/touch-gesture-scroll-div-scaled.html [ Failure ]
  fast/events/touch/page-scaled-touch-gesture-click.html [ Failure ]

http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/13078

[wjmaclean, 2013-06-27 17:35:52]

On 2013/06/27 17:19:26, Stephen White wrote:
> On 2013/06/27 16:47:44, I haz the power (commit-bot) wrote:
> > Change committed as 208942
> 
> This seems to be breaking ~8 layout tests on Linux (so far):
> 
> Regressions: Unexpected image and text failures (3)
>   fast/frames/frame-set-rotation-hit.html [ Failure ]
>   fast/frames/frame-set-scaling-hit.html [ Failure ]
>   scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html [ Failure
]
> 
> Regressions: Unexpected image-only failures (3)
>   compositing/gestures/gesture-tapHighlight-simple-scaled-document.html [
> ImageOnlyFailure ]
>   fast/repaint/fixed-in-page-scale.html [ ImageOnlyFailure ]
>   fast/repaint/fixed-right-in-page-scale.html [ ImageOnlyFailure ]
> 
> Regressions: Unexpected text-only failures (2)
>   fast/events/touch/gesture/touch-gesture-scroll-div-scaled.html [ Failure ]
>   fast/events/touch/page-scaled-touch-gesture-click.html [ Failure ]
> 
>
http://build.chromium.org/p/chromium.webkit/builders/WebKit%2520Linux/builds/...

Hmm, ok, probably best if we roll this out until I can figure out what's going
on in each case.