rAc - Only show countries we're able to fill in.

components/autofill/core/browser/form_structure.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_FORM_STRUCTURE_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_FORM_STRUCTURE_H_
 
+#include <set>
 #include <string>
 #include <vector>
 
 #include "base/callback.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "base/strings/string16.h"
 #include "components/autofill/core/browser/autofill_field.h"
 #include "components/autofill/core/browser/autofill_type.h"
@@ skipping 126 matching lines @@
       InputFieldComparator;
 
   // Fills in |fields_| that match |types| (via |matches|) with info from
   // |get_info|.
   bool FillFields(
       const std::vector<ServerFieldType>& types,
       const InputFieldComparator& matches,
       const base::Callback<base::string16(const AutofillType&)>& get_info,
       const std::string& app_locale);
 
+  // Returns the values that can be filled into the form structure for the
+  // given type. For example, there's no way to fill in a value of "The Moon"
+  // into ADDRESS_HOME_STATE if the form only has a
+  // <select autocomplete="region"> with no "The Moon" option. Returns an
+  // empty set if the form doesn't reference the given type or if all inputs
+  // are accepted (e.g., <input type="text" autocomplete="region">).
+  std::set<base::string16> PossibleValues(ServerFieldType type);

[Ilya Sherman, 2014/03/03 23:55:54]

'ServerFieldType' is a strange choice of type to pass to this method.  You
probably want an AutofillType instead.

[Ilya Sherman, 2014/03/03 23:55:54]

nit: This method name is rather vague.  Perhaps
"GetPossibleValuesForFieldType()" or something like that?

[Ilya Sherman, 2014/03/03 23:55:54]

You are expanding the public API of this class, so please add a unit test for
this method.

[Evan Stade, 2014/03/04 00:11:30]

I started with that, but it makes the call sites more verbose. ServerFieldType
is expressive enough to describe any type we could want to ask this question
about.

[Evan Stade, 2014/03/04 00:11:30]

Do you think it's vague when you see it in the context of the call site?

[Evan Stade, 2014/03/04 00:11:30]

See my other comment on why I think that is a bad idea.

[Ilya Sherman, 2014/03/04 00:53:57]

Yes, I do.  The call site just forwards a bunch of stuff to a constructor, so
the call site is really not very informative at all.  Besides, you're adding a
public method that might be called from other call sites in the future; so even
if the current call site was overwhelmingly clear, that would not mean that
future call sites would be.

[Ilya Sherman, 2014/03/04 00:53:57]

This code lives in a different component from the unittest code that you've
added.  Soon, it will run as part of a completely separate test binary.

If you prefer not to add test coverage to this class, then please move the
implementation of this code into the AutofillDialogController's anonymous
namespace.  In fact, now that I think about it, that's probably a better place
for this code regardless -- there's really no need to drop it into the shared
code.

+
   const AutofillField* field(size_t index) const;
   AutofillField* field(size_t index);
   size_t field_count() const;
 
   // Returns the number of fields that are able to be autofilled.
   size_t autofill_count() const { return autofill_count_; }
 
   // Used for iterating over the fields.
   std::vector<AutofillField*>::const_iterator begin() const {
     return fields_.begin();
@@ skipping 88 matching lines @@
   // Whether the form includes any field types explicitly specified by the site
   // author, via the |autocompletetype| attribute.
   bool has_author_specified_types_;
 
   DISALLOW_COPY_AND_ASSIGN(FormStructure);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_FORM_STRUCTURE_H_