Remove dependency of NaClHostMessageFilter code on Profiles.

Remove dependency of NaClHostMessageFilter code on Profiles.

Pass the needed parameters through the constructor instead of passing the profile itself.
This is part of en effort to componentize NaCl code.

BUG=244791
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208819

[yael.aharon1, 2013-06-26 14:18:18]

Removing the dependency on profiles is another small step in the process to
decouple NaCl code from the rest of chrome code.

Mark, can you please review? Thanks

[Mark Seaborn, 2013-06-26 14:45:34]

https://codereview.chromium.org/17826006/diff/1/chrome/browser/chrome_content...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/17826006/diff/1/chrome/browser/chrome_content...
chrome/browser/chrome_content_browser_client.cc:772:
host->GetChannel()->AddFilter(new NaClHostMessageFilter(id,
Please put 'id' on the following line for readability.

Preferred arg indentation styles are:

// ok
some_function(arg1, arg2,
              arg3,
              ...);
// ok
some_function(
    arg1, arg2,
    arg3,
    ...);

// not so good
some_function(arg1,
    arg2, ...);

https://codereview.chromium.org/17826006/diff/1/chrome/browser/nacl_host/nacl...
File chrome/browser/nacl_host/nacl_host_message_filter.h (right):

https://codereview.chromium.org/17826006/diff/1/chrome/browser/nacl_host/nacl...
chrome/browser/nacl_host/nacl_host_message_filter.h:61: // Copied from the
profile and it can be read on the IO thread.
It's unclear whether this comment applies to one member or multiple.  I don't
know if request_context_ and extension_info_map_ can be read on the IO thread. 
I think you should try to retain the meaning of the original comment.

[yael.aharon1, 2013-06-26 15:13:23]

On 2013/06/26 14:45:34, Mark Seaborn wrote:
>
https://codereview.chromium.org/17826006/diff/1/chrome/browser/chrome_content...
> File chrome/browser/chrome_content_browser_client.cc (right):
> 
>
https://codereview.chromium.org/17826006/diff/1/chrome/browser/chrome_content...
> chrome/browser/chrome_content_browser_client.cc:772:
> host->GetChannel()->AddFilter(new NaClHostMessageFilter(id,
> Please put 'id' on the following line for readability.
> 
> Preferred arg indentation styles are:
> 
> // ok
> some_function(arg1, arg2,
>               arg3,
>               ...);
> // ok
> some_function(
>     arg1, arg2,
>     arg3,
>     ...);
> 
> // not so good
> some_function(arg1,
>     arg2, ...);
> 
>
https://codereview.chromium.org/17826006/diff/1/chrome/browser/nacl_host/nacl...
> File chrome/browser/nacl_host/nacl_host_message_filter.h (right):
> 
>
https://codereview.chromium.org/17826006/diff/1/chrome/browser/nacl_host/nacl...
> chrome/browser/nacl_host/nacl_host_message_filter.h:61: // Copied from the
> profile and it can be read on the IO thread.
> It's unclear whether this comment applies to one member or multiple.  I don't
> know if request_context_ and extension_info_map_ can be read on the IO thread.

> I think you should try to retain the meaning of the original comment.

Thank you for reviewing, Mark. I fixed the nit, but I am not sure I understand
your second comment. Would you prefer if I don't change it at all?
My CL only adds one parameter for profile_directory_, and does not change the
meaning of any of the other parameters.

[Mark Seaborn, 2013-06-26 15:18:36]

https://codereview.chromium.org/17826006/diff/6001/chrome/browser/nacl_host/n...
File chrome/browser/nacl_host/nacl_host_message_filter.h (right):

https://codereview.chromium.org/17826006/diff/6001/chrome/browser/nacl_host/n...
chrome/browser/nacl_host/nacl_host_message_filter.h:61: // Copied from the
profile and it can be read on the IO thread.
How about: "off_the_record_ is copied from the profile partly so that it can be
read on the IO thread."

[yael.aharon1, 2013-06-26 18:32:53]

On 2013/06/26 15:18:36, Mark Seaborn wrote:
>
https://codereview.chromium.org/17826006/diff/6001/chrome/browser/nacl_host/n...
> File chrome/browser/nacl_host/nacl_host_message_filter.h (right):
> 
>
https://codereview.chromium.org/17826006/diff/6001/chrome/browser/nacl_host/n...
> chrome/browser/nacl_host/nacl_host_message_filter.h:61: // Copied from the
> profile and it can be read on the IO thread.
> How about: "off_the_record_ is copied from the profile partly so that it can
be
> read on the IO thread."

Done.

[Mark Seaborn, 2013-06-26 18:55:38]

LGTM

[commit-bot: I haz the power, 2013-06-26 18:59:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yael.aharon@intel.com/17826006/13001

[commit-bot: I haz the power, 2013-06-26 19:12:09]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2013-06-26 19:19:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yael.aharon@intel.com/17826006/20001

[commit-bot: I haz the power, 2013-06-26 21:06:11]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-06-26 21:07:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yael.aharon@intel.com/17826006/20001

[commit-bot: I haz the power, 2013-06-26 21:20:02]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-06-26 22:35:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yael.aharon@intel.com/17826006/20001

[commit-bot: I haz the power, 2013-06-26 23:33:04]

Change committed as 208819