Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4324)

Unified Diff: chrome/browser/ui/search/search_ipc_router.h

Issue 178253008: Redoing Issue 36073011: Allowing file:/// in Instant Extended's Most Visited links. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove unused consts. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search/search_ipc_router.h
diff --git a/chrome/browser/ui/search/search_ipc_router.h b/chrome/browser/ui/search/search_ipc_router.h
index 69dfb52f485fb8100b9ec786997c1402e8885fc0..22db1726ffe40d653b533fbf4077ed225944c945 100644
--- a/chrome/browser/ui/search/search_ipc_router.h
+++ b/chrome/browser/ui/search/search_ipc_router.h
@@ -63,8 +63,12 @@ class SearchIPCRouter : public content::WebContentsObserver {
virtual void OnLogEvent(NTPLoggingEventType event) = 0;
// Called to log an impression from a given provider on the New Tab Page.
- virtual void OnLogImpression(int position,
- const base::string16& provider) = 0;
+ virtual void OnLogMostVisitedImpression(int position,
+ const base::string16& provider) = 0;
+
+ // Called to log a navigation from a given provider on the New Tab Page.
+ virtual void OnLogMostVisitedNavigation(int position,
+ const base::string16& provider) = 0;
// Called when the page wants to paste the |text| (or the clipboard contents
// if the |text| is empty) into the omnibox.
@@ -187,9 +191,12 @@ class SearchIPCRouter : public content::WebContentsObserver {
void OnUndoMostVisitedDeletion(int page_id, const GURL& url) const;
void OnUndoAllMostVisitedDeletions(int page_id) const;
void OnLogEvent(int page_id, NTPLoggingEventType event) const;
- void OnLogImpression(int page_id,
- int position,
- const base::string16& provider) const;
+ void OnLogMostVisitedImpression(int page_id,
+ int position,
+ const base::string16& provider) const;
+ void OnLogMostVisitedNavigation(int page_id,
+ int position,
+ const base::string16& provider) const;
void OnPasteAndOpenDropDown(int page_id, const base::string16& text) const;
void OnChromeIdentityCheck(int page_id, const base::string16& identity) const;

Powered by Google App Engine
This is Rietveld 408576698