Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1631)

Unified Diff: chrome/browser/resources/local_ntp/most_visited_thumbnail.js

Issue 178253008: Redoing Issue 36073011: Allowing file:/// in Instant Extended's Most Visited links. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove unused consts. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/local_ntp/most_visited_thumbnail.js
diff --git a/chrome/browser/resources/local_ntp/most_visited_thumbnail.js b/chrome/browser/resources/local_ntp/most_visited_thumbnail.js
index 4f8b25ed64407a60f6c2ceeffe7f30b73999e96f..ff038a0fe48791039142f700f613070004b6ff08 100644
--- a/chrome/browser/resources/local_ntp/most_visited_thumbnail.js
+++ b/chrome/browser/resources/local_ntp/most_visited_thumbnail.js
@@ -14,8 +14,9 @@ window.addEventListener('DOMContentLoaded', function() {
function logEvent(eventName) {
chrome.embeddedSearch.newTabPage.logEvent(eventName);
}
- function logImpression(tileIndex, provider) {
- chrome.embeddedSearch.newTabPage.logImpression(tileIndex, provider);
+ function logMostVisitedImpression(tileIndex, provider) {
+ chrome.embeddedSearch.newTabPage.logMostVisitedImpression(
+ tileIndex, provider);
}
function displayLink(link) {
document.body.appendChild(link);
@@ -23,7 +24,7 @@ window.addEventListener('DOMContentLoaded', function() {
}
function showDomainElement() {
var link = createMostVisitedLink(
- params, data.url, data.title, undefined, data.ping, data.provider);
+ params, data.url, data.title, undefined, data.provider);
var domain = document.createElement('div');
domain.textContent = data.domain;
link.appendChild(domain);
@@ -33,7 +34,7 @@ window.addEventListener('DOMContentLoaded', function() {
// externally by the page itself.
function showEmptyTile() {
displayLink(createMostVisitedLink(
- params, data.url, data.title, undefined, data.ping, data.provider));
+ params, data.url, data.title, undefined, data.provider));
}
// Creates and adds an image.
function createThumbnail(src) {
@@ -42,8 +43,7 @@ window.addEventListener('DOMContentLoaded', function() {
var shadow = document.createElement('span');
shadow.classList.add('shadow');
var link = createMostVisitedLink(
- params, data.url, data.title, undefined, data.ping,
- data.provider);
+ params, data.url, data.title, undefined, data.provider);
link.appendChild(shadow);
link.appendChild(image);
displayLink(link);
@@ -63,7 +63,7 @@ window.addEventListener('DOMContentLoaded', function() {
// Log an impression if we know the position of the tile.
if (isFinite(params.pos) && data.provider) {
- logImpression(parseInt(params.pos, 10), data.provider);
+ logMostVisitedImpression(parseInt(params.pos, 10), data.provider);
}
logEvent(NTP_LOGGING_EVENT_TYPE.NTP_TILE);

Powered by Google App Engine
This is Rietveld 408576698