content/common/gpu/media/android_video_encode_accelerator.cc - Issue 178133005: Audit/fix use of media::VideoFrame::coded_size()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/android_video_encode_accelerator.cc

Issue 178133005: Audit/fix use of media::VideoFrame::coded_size() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: e6f9affb danakj@ comments. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/gpu/media/android_video_encode_accelerator.cc

diff --git a/content/common/gpu/media/android_video_encode_accelerator.cc b/content/common/gpu/media/android_video_encode_accelerator.cc

index 05f18b6b12513c318a1753885b416710447f41ca..910dda48e041abe3e0a18a7c9991eef2f9a4826d 100644

--- a/content/common/gpu/media/android_video_encode_accelerator.cc

+++ b/content/common/gpu/media/android_video_encode_accelerator.cc

@@ -208,8 +208,8 @@ void AndroidVideoEncodeAccelerator::Encode(

frame->stride(VideoFrame::kUPlane) &&

frame->row_bytes(VideoFrame::kVPlane) ==

frame->stride(VideoFrame::kVPlane) &&

- gfx::Rect(frame->coded_size()) == frame->visible_rect(),

- "Non-packed frame, or visible rect != coded size",

+ frame->coded_size() == frame->visible_rect().size(),

+ "Non-packed frame, or visible_rect != coded_size",

kInvalidArgumentError);

pending_frames_.push(MakeTuple(frame, force_keyframe, base::Time::Now()));