chrome/android/java/res/layout/bookmark_thumbnail_widget.xml - Issue 1780893005: Visual refresh for bookmarks widget.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/bookmark_thumbnail_widget.xml

Issue 1780893005: Visual refresh for bookmarks widget. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/drawable/bookmark_widget_thumb_selector.xml ('k') | chrome/android/java/res/layout/bookmark_thumbnail_widget_item.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/bookmark_thumbnail_widget.xml

diff --git a/chrome/android/java/res/layout/bookmark_thumbnail_widget.xml b/chrome/android/java/res/layout/bookmark_thumbnail_widget.xml

index 2f573f08794609053f343706402945e072f0d9f5..61af800df5dd424cf9432dec56c4318a12f89f9c 100644

--- a/chrome/android/java/res/layout/bookmark_thumbnail_widget.xml

+++ b/chrome/android/java/res/layout/bookmark_thumbnail_widget.xml

@@ -3,34 +3,11 @@

Use of this source code is governed by a BSD-style license that can be

found in the LICENSE file. -->

-<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"

+<ListView xmlns:android="http://schemas.android.com/apk/res/android"

+ android:id="@+id/bookmarks_list"

android:layout_width="match_parent"

- android:layout_height="match_parent" >

- <GridView

- android:id="@+id/bookmarks_list"

- android:layout_width="match_parent"

- android:layout_height="match_parent"

- android:background="@drawable/bg_bookmarks_widget_holo"

- android:columnWidth="@dimen/widget_column_width"

- android:drawSelectorOnTop="true"

- android:horizontalSpacing="@dimen/widget_horizontal_spacing"

- android:listSelector="@drawable/bookmark_widget_thumb_selector"

- android:numColumns="auto_fit"

- android:stretchMode="columnWidth"

- android:verticalSpacing="@dimen/widget_vertical_spacing" />

- <ImageButton

- android:id="@+id/app_shortcut"

- android:layout_width="wrap_content"

- android:layout_height="wrap_content"

- android:layout_alignParentBottom="true"

- android:layout_alignParentEnd="true"

- android:layout_marginBottom="4dp"

- android:layout_marginEnd="4dp"

- android:background="@drawable/bookmark_widget_thumb_selector"

- android:padding="4dp"

- android:src="@mipmap/app_icon"

- android:contentDescription="@string/accessibility_bookmark_widget_thumb_launch_chrome" />

-</RelativeLayout>

+ android:layout_height="match_parent"

+ android:background="#ddffffff"

+ android:divider="@null"

+ android:drawSelectorOnTop="true"

+ android:listSelector="@drawable/bookmark_widget_list_selector" />