Issue 17800002: Speed up SVG sprites by only painting the source rect in SVGImage::draw

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17800002: Speed up SVG sprites by only painting the source rect in SVGImage::draw (Closed)

Created:
7 years, 6 months ago by pdr.

Modified:
7 years, 6 months ago

Reviewers:
Stephen Chennney

CC:
blink-reviews, pdr, f(malita), Stephen Chennney, eae+blinkwatch

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Speed up SVG sprites by only painting the source rect in SVGImage::draw Previously we painted an entire SVG sprite image, even if only a small region was needed. This patch fixes this mistake by only painting the minimum required area. This patch takes a high-profile SVG scroll demo by adrianosmond from around ~10fps to 30+fps. A minimized example of this bug is at: philbit.com/sprites2.html (improved from less than 1fps to 30+fps) BUG=253091 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153069

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/core/svg/graphics/SVGImage.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/17800002/1

7 years, 6 months ago (2013-06-26 12:40:25 UTC) #3

Message was sent while issue was closed.

Change committed as 153069

Expand Messages | Collapse Messages