Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2287)

Unified Diff: chrome/android/java/res/layout/app_banner_view.xml

Issue 177863008: Update the AppBannerView appearance again (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Making highlight less finicky Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/app_banner_view.xml
diff --git a/chrome/android/java/res/layout/app_banner_view.xml b/chrome/android/java/res/layout/app_banner_view.xml
index cedea8f4d055d77ea90897035752919aa08fa919..b12a403953d5de1ec5978e89b1784cde7a7db8c3 100644
--- a/chrome/android/java/res/layout/app_banner_view.xml
+++ b/chrome/android/java/res/layout/app_banner_view.xml
@@ -10,27 +10,32 @@
android:background="@drawable/card_background_default"
android:layout_width="match_parent"
android:layout_height="wrap_content">
+ <!-- View showing the icon. -->
<ImageView
android:id="@+id/app_icon"
android:adjustViewBounds="true"
android:layout_width="wrap_content"
android:layout_height="@dimen/app_banner_icon_size"
android:layout_marginEnd="@dimen/app_banner_icon_margin_end" />
+
+ <!-- View showing the app's title. -->
<TextView
android:id="@+id/app_title"
android:textAppearance="@style/AppBannerTitle"
android:includeFontPadding="false"
- android:minLines="1"
- android:maxLines="1"
+ android:lines="1"
android:ellipsize="end"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginTop="@dimen/app_banner_title_margin_top"
android:layout_marginBottom="@dimen/app_banner_title_margin_bottom" />
+
+ <!-- Button that triggers installation and opening of the app. -->
<Button
android:id="@+id/app_install_button"
- android:background="@color/app_banner_install_button_bg"
+ android:background="@drawable/app_banner_button_install"
android:minHeight="@dimen/app_banner_button_height"
+ android:lines="1"
android:textAppearance="@style/AppBannerButton"
android:paddingStart="@dimen/app_banner_button_padding_sides"
android:paddingEnd="@dimen/app_banner_button_padding_sides"
@@ -40,16 +45,29 @@
android:layout_height="wrap_content"
android:layout_marginTop="@dimen/app_banner_button_margin_top"
android:layout_marginStart="@dimen/app_banner_button_margin_start" />
+
+ <!-- Logo for the store. -->
<ImageView
android:id="@+id/store_logo"
android:src="@drawable/google_play_logo"
android:adjustViewBounds="true"
android:layout_width="wrap_content"
android:layout_height="@dimen/app_banner_logo_height"
+ android:layout_marginTop="@dimen/app_banner_logo_margin_top"
android:layout_marginBottom="@dimen/app_banner_logo_margin_bottom" />
+
+ <!-- View showing how well the app is rated. -->
<org.chromium.chrome.browser.banners.RatingView
android:id="@+id/app_rating"
android:adjustViewBounds="true"
android:layout_width="wrap_content"
android:layout_height="@dimen/app_banner_star_height" />
+
+ <!-- View covering the entire banner. Used to indicate the banner is highlighted. -->
+ <View
+ android:id="@+id/banner_highlight"
+ android:background="@color/app_banner_card_highlight"
+ android:visibility="gone"
+ android:layout_width="fill_parent"
newt (away) 2014/02/25 19:22:28 match_parent (fill_parent was deprecated in the ea
gone 2014/02/25 20:26:11 I'm old school.
+ android:layout_height="fill_parent" />
</org.chromium.chrome.browser.banners.AppBannerView>

Powered by Google App Engine
This is Rietveld 408576698