chrome/android/java/res/values-h720dp/dimens.xml - Issue 177863008: Update the AppBannerView appearance again

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/values-h720dp/dimens.xml

Issue 177863008: Update the AppBannerView appearance again (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressing comments hopefully Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file.	4 found in the LICENSE file.

5 -->	5 -->

6	6

7 <resources>	7 <resources>

8 <!-- App banner dimensions -->	8 <!-- App banner dimensions -->

9 <dimen name="app_banner_max_width">570dp</dimen>	9 <dimen name="app_banner_max_width">570dp</dimen>

10 <dimen name="app_banner_margin_bottom">16dp</dimen>	10 <dimen name="app_banner_margin_bottom">16dp</dimen>

11	11

12 <dimen name="app_banner_button_text_size">16sp</dimen>	12 <dimen name="app_banner_button_text_size">16sp</dimen>

13 <dimen name="app_banner_button_height">34dp</dimen>	13 <dimen name="app_banner_button_height">34dp</dimen>

14 <dimen name="app_banner_button_padding_sides">16dp</dimen>	14 <dimen name="app_banner_button_padding_sides">16dp</dimen>

15	15

16 <dimen name="app_banner_icon_size">90dp</dimen>	16 <dimen name="app_banner_icon_size">90dp</dimen>

17 <dimen name="app_banner_icon_margin_end">16dp</dimen>	17 <dimen name="app_banner_icon_margin_end">16dp</dimen>

18	18

19 <dimen name="app_banner_title_text_size">21sp</dimen>	19 <dimen name="app_banner_title_text_size">21sp</dimen>

20 <dimen name="app_banner_title_margin_top">8dp</dimen>	20 <dimen name="app_banner_title_margin_top">2dp</dimen>

21	21

22 <dimen name="app_banner_logo_height">24dp</dimen>	22 <dimen name="app_banner_logo_height">26dp</dimen>

	23 <dimen name="app_banner_logo_margin_top">6dp</dimen>

23 <dimen name="app_banner_logo_margin_bottom">2dp</dimen>	24 <dimen name="app_banner_logo_margin_bottom">2dp</dimen>

24

25 <dimen name="app_banner_star_height">16dp</dimen>

26 </resources>	25 </resources>

OLD	NEW