chrome/android/java/res/drawable/app_banner_button_install.xml - Issue 177863008: Update the AppBannerView appearance again

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/drawable/app_banner_button_install.xml

Issue 177863008: Update the AppBannerView appearance again (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Making highlight less finicky Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/android/java/res/drawable-xxhdpi/google_play_logo.png ('k') | chrome/android/java/res/drawable/app_banner_button_install_default.xml » ('j') | chrome/android/java/res/layout/app_banner_view.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

	3

	4 Use of this source code is governed by a BSD-style license that can be

	5 found in the LICENSE file.

	6 -->

	7

	8 <selector xmlns:android="http://schemas.android.com/apk/res/android">

	9 <item android:drawable="@drawable/app_banner_button_install_pressed"
	newt (away) 2014/02/25 19:22:28 I believe you may be able to inline app_banner_but I believe you may be able to inline app_banner_button_install_default.xml and app_banner_button_install_pressed.xml into this file. Like so: <selector xmlns:android="http://schemas.android.com/apk/res/android"> <item android:state_pressed="true"> <shape><solid android:color="#b2cb39" /></shape> </item> <item android:state_pressed="true"> <shape><solid android:color="#d1dd94" /></shape> </item> </selector> Not tested, but I know that sort of nesting works with <layer-list> elements. Another option is: <selector xmlns:android="http://schemas.android.com/apk/res/android"> <item android:state_pressed="true" android:drawable="@color/my_favorite_color" /> <item android:state_pressed="true" android:drawable="@color/your_favorite_color" /> </selector> Or, for complete, you could use a ColorStateList (http://developer.android.com/guide/topics/resources/color-list-resource.html) gone 2014/02/25 20:26:11 Went with the former since the mock seems to keep Show quoted text On 2014/02/25 19:22:28, newt wrote: > I believe you may be able to inline app_banner_button_install_default.xml and > app_banner_button_install_pressed.xml into this file. Like so: > > <selector xmlns:android="http://schemas.android.com/apk/res/android"> > <item android:state_pressed="true"> > <shape><solid android:color="#b2cb39" /></shape> > </item> > <item android:state_pressed="true"> > <shape><solid android:color="#d1dd94" /></shape> > </item> > </selector> > > Not tested, but I know that sort of nesting works with <layer-list> elements. > Another option is: > > <selector xmlns:android="http://schemas.android.com/apk/res/android"> > <item android:state_pressed="true" > android:drawable="@color/my_favorite_color" /> > <item android:state_pressed="true" > android:drawable="@color/your_favorite_color" /> > </selector> > > Or, for complete, you could use a ColorStateList > (http://developer.android.com/guide/topics/resources/color-list-resource.html) Went with the former since the mock seems to keep changing.
	10 android:state_pressed="true" />

	11 <item android:drawable="@drawable/app_banner_button_install_default" />

	12 </selector>

OLD	NEW