Issue 17779003: Port base/files/file_util_proxy to Native Client.

Issue 17779003: Port base/files/file_util_proxy to Native Client. (Closed)

Created:
7 years, 6 months ago by bbudge

Modified:
7 years, 5 months ago

Reviewers:
brettw

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Port base/files/file_util_proxy to Native Client. There is a lot here that we will never implement in NaCl. Use #ifdefs to port enough to allow us to use FileUtilProxy to implement blocking file operations in NaCl. BUG=194304 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211271

Patch Set 1 : #

Patch Set 2 : Add TODO to remove NaCl pread/pwrite workarounds. #

Total comments: 2

Patch Set 3 : Move NaCl workaround into platform_file_posix.cc. #

Total comments: 2

Patch Set 4 : Reduce #ifdef's. #

Patch Set 5 : Fix build when __USE_XOPEN2K8 is defined. #

Total comments: 3

Patch Set 6 : Add platform_file_nacl.cc file. #

Patch Set 7 : Remove platform_file_nacl.cc. #

Patch Set 8 : Comment tweaks. #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+113 lines, -26 lines)			Patch
M	base/base.gypi	View	1 2 3 4 5 6	1 chunk	+0 lines, -2 lines	0 comments	Download
M	base/files/file_util_proxy.cc	View	1 2 3 4 5 6	14 chunks	+16 lines, -1 line	0 comments	Download
M	base/platform_file.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	base/platform_file_posix.cc	View	1 2 3 4 5 6 7	10 chunks	+95 lines, -23 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

bbudge

Context: this is needed for https://codereview.chromium.org/18063005/

7 years, 5 months ago (2013-07-01 18:22:13 UTC) #1

brettw

https://codereview.chromium.org/17779003/diff/17001/base/files/file_util_proxy.cc File base/files/file_util_proxy.cc (right): https://codereview.chromium.org/17779003/diff/17001/base/files/file_util_proxy.cc#newcode151 base/files/file_util_proxy.cc:151: SeekPlatformFile(file, PLATFORM_FILE_FROM_BEGIN, offset); Does it make more sense to ...

7 years, 5 months ago (2013-07-09 20:05:37 UTC) #2

bbudge

7 years, 5 months ago (2013-07-09 21:54:54 UTC) #3

brettw

https://codereview.chromium.org/17779003/diff/24001/base/files/file_util_proxy.cc File base/files/file_util_proxy.cc (right): https://codereview.chromium.org/17779003/diff/24001/base/files/file_util_proxy.cc#newcode209 base/files/file_util_proxy.cc:209: #endif // !defined(OS_NACL) This should go one line higher

7 years, 5 months ago (2013-07-10 21:35:18 UTC) #4

bbudge

I reduced the #ifdef'ing by defining wrapper functions at the top. Not sure if it's ...

7 years, 5 months ago (2013-07-10 22:09:39 UTC) #5

brettw

lgtm https://codereview.chromium.org/17779003/diff/42001/base/platform_file_posix.cc File base/platform_file_posix.cc (right): https://codereview.chromium.org/17779003/diff/42001/base/platform_file_posix.cc#newcode46 base/platform_file_posix.cc:46: // TODO(bbudge) Remove NaCl workarounds when it implements ...

7 years, 5 months ago (2013-07-11 18:02:43 UTC) #6

bbudge

https://codereview.chromium.org/17779003/diff/42001/base/platform_file_posix.cc File base/platform_file_posix.cc (right): https://codereview.chromium.org/17779003/diff/42001/base/platform_file_posix.cc#newcode46 base/platform_file_posix.cc:46: // TODO(bbudge) Remove NaCl workarounds when it implements pread ...

7 years, 5 months ago (2013-07-11 20:08:23 UTC) #7

bbudge

7 years, 5 months ago (2013-07-11 20:13:18 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/17779003/5681726336532480

7 years, 5 months ago (2013-07-11 20:14:30 UTC) #9

Message was sent while issue was closed.

Change committed as 211271

Expand Messages | Collapse Messages