Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2831)

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h

Issue 17774002: OmniboxPopupViewMac refactoring Part 3 (truncation) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h
diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h
index da3b5457c6ce56f81fba2f0f5087fc2cb418fe3c..127b61adbb7a92f24e3044aad327de67d51db127 100644
--- a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h
+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h
@@ -50,13 +50,6 @@ class OmniboxPopupViewMac : public OmniboxPopupView,
OmniboxPopupMatrix* matrix() { return matrix_; }
- // Return the text to show for the match, based on the match's
- // contents and description. Result will be in |font|, with the
- // boldfaced version used for matches.
- static NSAttributedString* MatchText(const AutocompleteMatch& match,
- gfx::Font& font,
- float cell_width);
-
// Applies the given font and colors to the match string based on
// classifications.
static NSMutableAttributedString* DecorateMatchedString(
@@ -66,18 +59,6 @@ class OmniboxPopupViewMac : public OmniboxPopupView,
NSColor* dim_text_color,
gfx::Font& font);
- // Helper for MatchText() to elide a marked-up string using
- // gfx::ElideText() as a model. Modifies |a_string| in place.
- // TODO(shess): Consider breaking AutocompleteButtonCell out of this
- // code, and modifying it to have something like -setMatch:, so that
- // these convolutions to expose internals for testing can be
- // cleaner.
- static NSMutableAttributedString* ElideString(
- NSMutableAttributedString* a_string,
- const string16& original_string,
- const gfx::Font& font,
- const float cell_width);
-
protected:
// Gets the autocomplete results. This is virtual so that it can be overriden
// by tests.

Powered by Google App Engine
This is Rietveld 408576698