Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Unified Diff: net/spdy/spdy_websocket_stream_unittest.cc

Issue 17760008: [SPDY] Enable tests for SPDY/3.1 and SPDY/4 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_test_util_common.cc ('k') | net/websockets/websocket_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_websocket_stream_unittest.cc
diff --git a/net/spdy/spdy_websocket_stream_unittest.cc b/net/spdy/spdy_websocket_stream_unittest.cc
index 174b4f9b298354b9702546ea7a160b0e1e7a43ea..5a64afe405b9d06bcfeefb6195abc10007cdfedf 100644
--- a/net/spdy/spdy_websocket_stream_unittest.cc
+++ b/net/spdy/spdy_websocket_stream_unittest.cc
@@ -325,13 +325,7 @@ const size_t SpdyWebSocketStreamTest::kMessageFrameLength =
const size_t SpdyWebSocketStreamTest::kClosingFrameLength =
arraysize(SpdyWebSocketStreamTest::kClosingFrame) - 1;
-// TODO(akalin): Don't early-exit in the tests below for values >
-// kProtoSPDY3.
-
TEST_P(SpdyWebSocketStreamTest, Basic) {
- if (GetParam() > kProtoSPDY3)
- return;
-
Prepare(1);
MockWrite writes[] = {
CreateMockWrite(*request_frame_.get(), 1),
@@ -408,9 +402,6 @@ TEST_P(SpdyWebSocketStreamTest, Basic) {
}
TEST_P(SpdyWebSocketStreamTest, DestructionBeforeClose) {
- if (GetParam() > kProtoSPDY3)
- return;
-
Prepare(1);
MockWrite writes[] = {
CreateMockWrite(*request_frame_.get(), 1),
@@ -473,9 +464,6 @@ TEST_P(SpdyWebSocketStreamTest, DestructionBeforeClose) {
}
TEST_P(SpdyWebSocketStreamTest, DestructionAfterExplicitClose) {
- if (GetParam() > kProtoSPDY3)
- return;
-
Prepare(1);
MockWrite writes[] = {
CreateMockWrite(*request_frame_.get(), 1),
@@ -537,9 +525,6 @@ TEST_P(SpdyWebSocketStreamTest, DestructionAfterExplicitClose) {
}
TEST_P(SpdyWebSocketStreamTest, IOPending) {
- if (GetParam() > kProtoSPDY3)
- return;
-
Prepare(1);
scoped_ptr<SpdyFrame> settings_frame(
spdy_util_.ConstructSpdySettings(spdy_settings_to_send_));
« no previous file with comments | « net/spdy/spdy_test_util_common.cc ('k') | net/websockets/websocket_job_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698