VAVDA: Switch to using max_num_reorder_frames.

media/filters/h264_parser.h

Index: media/filters/h264_parser.h
diff --git a/media/filters/h264_parser.h b/media/filters/h264_parser.h
index 2f214c7f6ebab0c4428738d6d6d36443eca1c303..cd43c4265fb6e7eddac5c5898578bb7874e7d447 100644
--- a/media/filters/h264_parser.h
+++ b/media/filters/h264_parser.h
@@ -53,7 +53,7 @@ struct MEDIA_EXPORT H264SPS {
   H264SPS();
 
   int profile_idc;
-  int constraint_setx_flag;
+  bool constraint_setx_flag[6];

[Ami GONE FROM CHROMIUM, 2014/02/25 09:45:37]

This is C++ so bool is int8_t so bool[] is a pretty good way of confusing
readers, IMO.
Why the change?

[Pawel Osciak, 2014/02/26 06:02:15]

So this was actually used to store all six flags (6 bits) before. Now we keep
each of them separately and treat them as all the other *_flag variables in this
struct, i.e. actual bools.

For me this way is definitely less confusing. Why would this be more confusing?

[Ami GONE FROM CHROMIUM, 2014/02/26 17:15:58]

In the spec the bits are packed.  Using a bool[] _looks_ like a packet array of
bits, but in fact is a uint8[] where each uint8 carries one bit of information
and 7 bits of empty space.

I'd say either the old approach (single int to hold 6 bits) or 6 separate bool
fields (like what the spec does) would be fine, but a bool[] is pretty much the
worst choice.

   int level_idc;
   int seq_parameter_set_id;
 
@@ -88,10 +88,15 @@ struct MEDIA_EXPORT H264SPS {
   int frame_crop_right_offset;
   int frame_crop_top_offset;
   int frame_crop_bottom_offset;
+
   bool vui_parameters_present_flag;
-  int chroma_array_type;
   int sar_width;    // Set to 0 when not specified.
   int sar_height;   // Set to 0 when not specified.
+  bool bitstream_restriction_flag;
+  int max_num_reorder_frames;
+  int max_dec_frame_buffering;
+
+  int chroma_array_type;
 };
 
 struct MEDIA_EXPORT H264PPS {
@@ -344,6 +349,11 @@ class MEDIA_EXPORT H264Parser {
   Result ParseSPSScalingLists(H264SPS* sps);
   Result ParsePPSScalingLists(const H264SPS& sps, H264PPS* pps);
 
+  // Parse optional VUI parameters in SPS (see spec).
+  Result ParseVUIParameters(H264SPS* sps);
+  // Set |hrd_parameters_present| to true only if they are present.
+  Result ParseAndIgnoreHRDParameters(bool* hrd_parameters_present);
+
   // Parse reference picture lists' modifications (see spec).
   Result ParseRefPicListModifications(H264SliceHeader* shdr);
   Result ParseRefPicListModification(int num_ref_idx_active_minus1,