Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 1774763002: Plumb DemuxerStream::EnableBitstreamConverter through mojo pipeline. (Closed)

Created:
4 years, 9 months ago by alokp
Modified:
4 years, 9 months ago
Reviewers:
xhwang
CC:
chromium-reviews, qsr+mojo_chromium.org, feature-media-reviews_chromium.org, lcwu+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, halliwell+watch_chromium.org, gunsch+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plumb DemuxerStream::EnableBitstreamConverter through mojo pipeline. BUG=592114 Committed: https://crrev.com/198d663363a342e390d57e789558e66fd63ef800 Cr-Commit-Position: refs/heads/master@{#379856}

Patch Set 1 #

Total comments: 3

Patch Set 2 : added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M chromecast/browser/media/cast_renderer.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M media/mojo/interfaces/demuxer_stream.mojom View 1 1 chunk +4 lines, -0 lines 0 comments Download
M media/mojo/services/mojo_demuxer_stream_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/mojo_demuxer_stream_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/mojo/services/mojo_demuxer_stream_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
alokp
4 years, 9 months ago (2016-03-08 00:19:57 UTC) #2
xhwang
LGTM % tiny nit https://chromiumcodereview.appspot.com/1774763002/diff/1/media/mojo/interfaces/demuxer_stream.mojom File media/mojo/interfaces/demuxer_stream.mojom (right): https://chromiumcodereview.appspot.com/1774763002/diff/1/media/mojo/interfaces/demuxer_stream.mojom#newcode57 media/mojo/interfaces/demuxer_stream.mojom:57: EnableBitstreamConverter(); Could you please add ...
4 years, 9 months ago (2016-03-08 01:36:46 UTC) #3
alokp
https://chromiumcodereview.appspot.com/1774763002/diff/1/media/mojo/interfaces/demuxer_stream.mojom File media/mojo/interfaces/demuxer_stream.mojom (right): https://chromiumcodereview.appspot.com/1774763002/diff/1/media/mojo/interfaces/demuxer_stream.mojom#newcode57 media/mojo/interfaces/demuxer_stream.mojom:57: EnableBitstreamConverter(); On 2016/03/08 01:36:46, xhwang wrote: > Could you ...
4 years, 9 months ago (2016-03-08 05:22:42 UTC) #4
xhwang
https://chromiumcodereview.appspot.com/1774763002/diff/1/media/mojo/interfaces/demuxer_stream.mojom File media/mojo/interfaces/demuxer_stream.mojom (right): https://chromiumcodereview.appspot.com/1774763002/diff/1/media/mojo/interfaces/demuxer_stream.mojom#newcode57 media/mojo/interfaces/demuxer_stream.mojom:57: EnableBitstreamConverter(); On 2016/03/08 05:22:42, alokp wrote: > On 2016/03/08 ...
4 years, 9 months ago (2016-03-08 06:34:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1774763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1774763002/20001
4 years, 9 months ago (2016-03-08 17:26:06 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-08 18:06:22 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 18:07:25 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/198d663363a342e390d57e789558e66fd63ef800
Cr-Commit-Position: refs/heads/master@{#379856}

Powered by Google App Engine
This is Rietveld 408576698