Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 17743005: [Autofill] Ignore device scale factor when computing the Autofill popup position. (Closed)

Created:
7 years, 6 months ago by Ilya Sherman
Modified:
7 years, 5 months ago
CC:
chromium-reviews, Raman Kakilate, benquan, ahutter, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

[Autofill] Ignore device scale factor when computing the Autofill popup position. BUG=246468 TEST=The Autofill popup should be positioned correctly in the following setup: (a) Get a Mac OS X setup where one screen is a non-Retina display, and the other is. (b) In System Preferences ~> Displays ~> Arrangement, position the non-retina display above the retina display. (c) Open a browser window on the retina display, and bring up an Autofill popup in this window. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208872

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M chrome/browser/ui/autofill/autofill_popup_controller_impl.cc View 2 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Ilya Sherman
I've manually verified that this appears to work correctly on Mac OS X 10.8.4. Chris, ...
7 years, 6 months ago (2013-06-26 00:18:15 UTC) #1
Scott Hess - ex-Googler
LGTM for OSX, I think these days this kind of thing shouldn't be necessary, unless ...
7 years, 6 months ago (2013-06-26 00:36:41 UTC) #2
Ilya Sherman
On 2013/06/26 00:36:41, shess wrote: > LGTM for OSX, I think these days this kind ...
7 years, 6 months ago (2013-06-26 00:38:42 UTC) #3
csharp
On 2013/06/26 00:18:15, Ilya Sherman wrote: > I've manually verified that this appears to work ...
7 years, 6 months ago (2013-06-26 12:54:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/17743005/1
7 years, 5 months ago (2013-06-26 20:54:37 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-06-26 21:14:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/17743005/1
7 years, 5 months ago (2013-06-26 21:44:17 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-06-27 01:04:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/17743005/1
7 years, 5 months ago (2013-06-27 01:09:09 UTC) #9
commit-bot: I haz the power
7 years, 5 months ago (2013-06-27 09:19:24 UTC) #10
Message was sent while issue was closed.
Change committed as 208872

Powered by Google App Engine
This is Rietveld 408576698