Add custom hooks.

Add custom hooks.

Sometimes we wish to pull in a complicated dependency but want to
suppress or replace one or more of the hooks rules.  Say for example
we want to use a different way of generating the projects, or
have a different set of landmine expectations.

Here we add a custom_hooks section mirroring custom_deps to allow us to
override sections we have identified in the DEPS file.  To do so,
we add an optional name to the elements of the hooks list, and overwrite
those whose name matches.

Conventions between included DEPS and the .gclient as to the meanings of the
name are equivalent to the meaning of the customized deps, and so do not
benefit from further structure or definition.

BUG=None
TEST=local unit test

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=210573

[Peter Mayo, 2013-06-26 22:22:04]

Switching from M-A while he's OOO.

[szager1, 2013-06-28 15:42:34]

https://codereview.chromium.org/17742004/diff/1/gclient.py
File gclient.py (right):

https://codereview.chromium.org/17742004/diff/1/gclient.py#newcode54
gclient.py:54: "action":  ["gyp_chromium"]},
I'd rather the action was the same as it is in DEPS:

"action": ["python", "src/build/gyp_chromium"]},

https://codereview.chromium.org/17742004/diff/1/gclient.py#newcode548
gclient.py:548: hook_names_to_suppress = [c.get('name', '') for c in
self.custom_hooks]
suppress = [c['name'] for c in self.custom_hooks if 'name' in c]

https://codereview.chromium.org/17742004/diff/1/gclient.py#newcode550
gclient.py:550: if hook.get('name', '') not in hook_names_to_suppress:
if 'name' in hook and hook['name'] not in suppress:

https://codereview.chromium.org/17742004/diff/1/gclient.py#newcode554
gclient.py:554: for hook in self.custom_hooks:
As written, will the custom hooks be re-added for *every* DEPS file parsed?

[Peter Mayo, 2013-06-28 17:04:34]

https://codereview.chromium.org/17742004/diff/1/gclient.py
File gclient.py (right):

https://codereview.chromium.org/17742004/diff/1/gclient.py#newcode548
gclient.py:548: hook_names_to_suppress = [c.get('name', '') for c in
self.custom_hooks]
On 2013/06/28 15:42:34, szager1 wrote:
> suppress = [c['name'] for c in self.custom_hooks if 'name' in c]

That would leave no way to suppress all of the empty named hooks.

https://codereview.chromium.org/17742004/diff/1/gclient.py#newcode550
gclient.py:550: if hook.get('name', '') not in hook_names_to_suppress:
On 2013/06/28 15:42:34, szager1 wrote:
> if 'name' in hook and hook['name'] not in suppress:

Same as above, I was meaning that 

custom_hooks = [{"action": None}] meant don't use the unnamed hooks,
and custom_hooks = [{<1>},{<2>],{<3>}] would mean use these in stead.

(note that appending a custom hooks is still easy since you just give it an
unused name, like your email}

Does it make more sense to you to only be able to override named hooks?

https://codereview.chromium.org/17742004/diff/1/gclient.py#newcode554
gclient.py:554: for hook in self.custom_hooks:
On 2013/06/28 15:42:34, szager1 wrote:
> As written, will the custom hooks be re-added for *every* DEPS file parsed?

Will check that case.

[Peter Mayo, 2013-06-28 17:19:32]

https://codereview.chromium.org/17742004/diff/1/gclient.py
File gclient.py (right):

https://codereview.chromium.org/17742004/diff/1/gclient.py#newcode54
gclient.py:54: "action":  ["gyp_chromium"]},
On 2013/06/28 15:42:34, szager1 wrote:
> I'd rather the action was the same as it is in DEPS:
> 
> "action": ["python", "src/build/gyp_chromium"]},

Done.

[Peter Mayo, 2013-06-28 18:00:12]

Incrementals finished - just waiting on agreement or continued discussion of the
meaning of specifying unnamed custom_hooks.

ch=[{".", "cmd"}] + dh=[{".","cmd1"},{".","cmd2"}]

= [{".","cmd1"},{".","cmd2"},{".","cmd"}]

or

= [{".", "cmd"}]



I wrote and prefer the latter, since I can do the first by appending
"name":"petermayo-fu" to the custom_hooks in my .gclient

https://codereview.chromium.org/17742004/diff/1/gclient.py
File gclient.py (right):

https://codereview.chromium.org/17742004/diff/1/gclient.py#newcode554
gclient.py:554: for hook in self.custom_hooks:
On 2013/06/28 17:04:35, Peter Mayo wrote:
> On 2013/06/28 15:42:34, szager1 wrote:
> > As written, will the custom hooks be re-added for *every* DEPS file parsed?
> 
> Will check that case.

The custom_hooks for each DEPS are processed exactly once, when the DEP is
processed.

I added a test to ensure that subsequent DEPS are not affected by previous
custom_hooks.

[Peter Mayo, 2013-07-03 01:31:06]

ping

[Peter Mayo, 2013-07-04 13:18:05]

I guess szager1 is too busy for this.

[M-A Ruel, 2013-07-08 18:01:20]

lgtm

[commit-bot: I haz the power, 2013-07-09 14:38:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/petermayo@chromium.org/17742004/11001

[commit-bot: I haz the power, 2013-07-09 14:40:37]

Change committed as 210573