Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Unified Diff: recipe_modules/json/test_api.py

Issue 1773273003: Make output placeholders like json.output index-able by name. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/recipes-py@master
Patch Set: Rebase uppon https://codereview.chromium.org/1785543004/ Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: recipe_modules/json/test_api.py
diff --git a/recipe_modules/json/test_api.py b/recipe_modules/json/test_api.py
index d807a4acf1be86e23f75c9683c80b1da70011008..196e7c1b37db220d75faee049360392516247a16 100644
--- a/recipe_modules/json/test_api.py
+++ b/recipe_modules/json/test_api.py
@@ -9,11 +9,12 @@ from recipe_engine import recipe_test_api
class JsonTestApi(recipe_test_api.RecipeTestApi):
@recipe_test_api.placeholder_step_data
@staticmethod
- def output(data, retcode=None):
- return json.dumps(data), retcode
+ def output(data, retcode=None, name=None):
+ return json.dumps(data), retcode, name
- def output_stream(self, data, stream='stdout', retcode=None):
+ def output_stream(self, data, stream='stdout', retcode=None, name=None):
assert stream in ('stdout', 'stderr')
ret = recipe_test_api.StepTestData()
- setattr(ret, stream, self.output(data, retcode).unwrap_output_placeholder())
+ step_data = self.output(data, retcode=retcode, name=name)
+ setattr(ret, stream, step_data.unwrap_output_placeholder())
return ret

Powered by Google App Engine
This is Rietveld 408576698