sql/connection.cc - Issue 17726002: [sql] Callback and scoped-ignore tests for sql::Statement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sql/connection.cc

Issue 17726002: [sql] Callback and scoped-ignore tests for sql::Statement. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: prevent nesting, TODO. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sql/connection.cc

diff --git a/sql/connection.cc b/sql/connection.cc

index f04eb3bd7ee3c135892fd9225043e59fdcaf6eed..06dc8889dad075aa819b067edc18f0b8b41108bb 100644

--- a/sql/connection.cc

+++ b/sql/connection.cc

@@ -860,7 +860,10 @@ int Connection::OnSqliteError(int err, sql::Statement *stmt) {

<< ": " << GetErrorMessage();

if (!error_callback_.is_null()) {

- error_callback_.Run(err, stmt);

+ // Fire from a copy of the callback in case of reentry into

+ // re/set_error_callback().

+ // TODO(shess): <http://crbug.com/254584>

+ ErrorCallback(error_callback_).Run(err, stmt);

return err;

}

« no previous file with comments | « sql/connection.h ('k') | sql/connection_unittest.cc » ('j') | no next file with comments »