Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 17703003: Do not assume that every subproject needs to contain a diff. (Closed)

Created:
7 years, 5 months ago by iannucci
Modified:
7 years, 5 months ago
Reviewers:
Dirk Pranke, M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org
Visibility:
Public.

Description

Do not assume that every subproject needs to contain a diff. This is especially useful when you want to do something like: git try -s third_party/WebKit from the chromium root checkout. R=dpranke@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=210409

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M trychange.py View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
iannucci
7 years, 5 months ago (2013-06-25 18:42:54 UTC) #1
Dirk Pranke
lgtm
7 years, 5 months ago (2013-07-02 23:34:50 UTC) #2
M-A Ruel
lgtm
7 years, 5 months ago (2013-07-08 18:45:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/17703003/1
7 years, 5 months ago (2013-07-08 20:26:29 UTC) #4
commit-bot: I haz the power
7 years, 5 months ago (2013-07-08 20:28:51 UTC) #5
Message was sent while issue was closed.
Change committed as 210409

Powered by Google App Engine
This is Rietveld 408576698