Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1747)

Unified Diff: media/mojo/interfaces/media_types.mojom

Issue 1769673002: Transfer media::VideoFrame using mojo shared memory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/mojo/common/mojo_shared_buffer_video_frame.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mojo/interfaces/media_types.mojom
diff --git a/media/mojo/interfaces/media_types.mojom b/media/mojo/interfaces/media_types.mojom
index 085256eac3a139d30c26905ba51c1d4dd508dd21..d04f434eb537f012912427fd3b1ae934354c9fa0 100644
--- a/media/mojo/interfaces/media_types.mojom
+++ b/media/mojo/interfaces/media_types.mojom
@@ -266,8 +266,6 @@ struct AudioBuffer {
};
// This defines a mojo transport format for media::VideoFrame.
-// TODO(jrummell): Support shared memory based VideoFrame to avoid copying
-// the data multiple times.
struct VideoFrame {
// Format of the frame.
VideoFormat format;
@@ -287,8 +285,16 @@ struct VideoFrame {
// Timestamp in microseconds of the associated frame.
int64 timestamp_usec;
- // Frame data for each plane. Will be null for EOS buffers.
- array<uint8>? y_data;
- array<uint8>? u_data;
- array<uint8>? v_data;
+ // Reference to the shared memory containing the frame's data.
+ handle<shared_buffer> frame_data;
+ uint64 frame_data_size;
+
+ // Stride and offsets for each plane. Offsets are relative to the start
+ // of |frame_data|.
+ int32 y_stride;
+ int32 u_stride;
+ int32 v_stride;
+ int32 y_offset;
+ int32 u_offset;
+ int32 v_offset;
};
« no previous file with comments | « media/mojo/common/mojo_shared_buffer_video_frame.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698