Issue 17684002: Remove no longer needed stuff from chromeos build script, always run gyp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17684002: Remove no longer needed stuff from chromeos build script, always run gyp (Closed)

Created:
7 years, 6 months ago by borenet

Modified:
7 years, 6 months ago

Reviewers:
djsollen

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Remove no longer needed stuff from chromeos build script, always run gyp (RunBuilders:Test-ChromeOS-Alex-GMA3150-x86-Debug,Test-ChromeOS-Alex-GMA3150-x86-Release,Perf-ChromeOS-Alex-GMA3150-x86-Release) Committed: http://code.google.com/p/skia/source/detail?r=9752

Patch Set 1 #

Total comments: 1

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -16 lines)			Patch
	M	platform_tools/chromeos/bin/build_skia_in_chroot	View		1 chunk	+1 line, -16 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

borenet

https://codereview.chromium.org/17684002/diff/1/platform_tools/chromeos/bin/build_skia_in_chroot File platform_tools/chromeos/bin/build_skia_in_chroot (left): https://codereview.chromium.org/17684002/diff/1/platform_tools/chromeos/bin/build_skia_in_chroot#oldcode36 platform_tools/chromeos/bin/build_skia_in_chroot:36: # Copy missing headers and libraries into the sysroot. ...

7 years, 6 months ago (2013-06-25 15:27:54 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/borenet@google.com/17684002/1

7 years, 6 months ago (2013-06-25 18:07:30 UTC) #3

Message was sent while issue was closed.

Change committed as 9752

Expand Messages | Collapse Messages