Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1205)

Unified Diff: scripts/slave/recipes/findit/chromium/compile.expected/compile_none_existing_targets.json

Issue 1766863002: [Findit] Check existence of given targets before running compile in recipe findit/chromium/compile. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@setup_local_test
Patch Set: . Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/findit/chromium/compile.expected/compile_none_existing_targets.json
diff --git a/scripts/slave/recipes/findit/chromium/compile.expected/compile_specified_targets.json b/scripts/slave/recipes/findit/chromium/compile.expected/compile_none_existing_targets.json
similarity index 95%
copy from scripts/slave/recipes/findit/chromium/compile.expected/compile_specified_targets.json
copy to scripts/slave/recipes/findit/chromium/compile.expected/compile_none_existing_targets.json
index b53c3efd1ceeeb6cce970c00083411ba75495c44..d7c3e507fd9630e6246f8d9aabd02b3f244a5042 100644
--- a/scripts/slave/recipes/findit/chromium/compile.expected/compile_specified_targets.json
+++ b/scripts/slave/recipes/findit/chromium/compile.expected/compile_none_existing_targets.json
@@ -370,18 +370,6 @@
"cmd": [
"python",
"-u",
- "[BUILD]/scripts/slave/cleanup_temp.py"
- ],
- "cwd": "[SLAVE_BUILD]",
- "name": "test r1.cleanup_temp",
- "~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@"
- ]
- },
- {
- "cmd": [
- "python",
- "-u",
"[SLAVE_BUILD]/src/tools/mb/mb.py",
"gen",
"-m",
@@ -404,29 +392,25 @@
"cmd": [
"python",
"-u",
- "[BUILD]/scripts/slave/compile.py",
+ "[BUILD]/scripts/slave/check_target_existence.py",
+ "--target-build-dir",
+ "[SLAVE_BUILD]/src/out/Release",
"--target",
- "Release",
- "--src-dir",
- "[SLAVE_BUILD]/src",
- "--build-tool",
- "ninja",
- "--compiler",
- "goma",
- "--goma-jsonstatus",
- "/path/to/tmp/json",
- "--goma-dir",
- "[SLAVE_BUILD]/src/build/goma/client",
- "--ninja-ensure-up-to-date",
- "--",
- "target_name"
+ "gen/a/b/source.cc",
+ "--json-output",
+ "/path/to/tmp/json"
],
"cwd": "[SLAVE_BUILD]",
- "name": "test r1.compile",
+ "name": "test r1.check_targets",
"~followup_annotations": [
"@@@STEP_NEST_LEVEL@1@@@",
- "@@@STEP_LOG_LINE@json.output (invalid)@null@@@",
- "@@@STEP_LOG_END@json.output (invalid)@@@"
+ "@@@STEP_LOG_LINE@json.output@{@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"found\": [], @@@",
+ "@@@STEP_LOG_LINE@json.output@ \"not_found\": [@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"gen/a/b/source.cc\"@@@",
+ "@@@STEP_LOG_LINE@json.output@ ]@@@",
+ "@@@STEP_LOG_LINE@json.output@}@@@",
+ "@@@STEP_LOG_END@json.output@@@"
]
},
{
@@ -440,14 +424,14 @@
"~followup_annotations": [
"@@@STEP_LOG_LINE@report@{@@@",
"@@@STEP_LOG_LINE@report@ \"result\": {@@@",
- "@@@STEP_LOG_LINE@report@ \"r1\": \"passed\"@@@",
+ "@@@STEP_LOG_LINE@report@ \"r1\": \"skipped\"@@@",
"@@@STEP_LOG_LINE@report@ }, @@@",
"@@@STEP_LOG_LINE@report@ \"metadata\": {@@@",
"@@@STEP_LOG_LINE@report@ \"regression_range_size\": 1@@@",
"@@@STEP_LOG_LINE@report@ }@@@",
"@@@STEP_LOG_LINE@report@}@@@",
"@@@STEP_LOG_END@report@@@",
- "@@@SET_BUILD_PROPERTY@report@{\"metadata\": {\"regression_range_size\": 1}, \"result\": {\"r1\": \"passed\"}}@@@"
+ "@@@SET_BUILD_PROPERTY@report@{\"metadata\": {\"regression_range_size\": 1}, \"result\": {\"r1\": \"skipped\"}}@@@"
]
},
{

Powered by Google App Engine
This is Rietveld 408576698