scripts/slave/recipes/findit/chromium/compile.expected/compile_specified_targets.json - Issue 1766863002: [Findit] Check existence of given targets before running compile in recipe findit/chromium/compile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/findit/chromium/compile.expected/compile_specified_targets.json

Issue 1766863002: [Findit] Check existence of given targets before running compile in recipe findit/chromium/compile. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@setup_local_test

Patch Set: Rebase. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/findit/chromium/compile.expected/compile_none_existing_targets.json ('k') | scripts/slave/recipes/findit/chromium/compile.expected/failed_compile_upon_infra_failure.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/findit/chromium/compile.expected/compile_specified_targets.json

diff --git a/scripts/slave/recipes/findit/chromium/compile.expected/compile_specified_targets.json b/scripts/slave/recipes/findit/chromium/compile.expected/compile_specified_targets.json

index 7574a9ac4eecade25722a42c71b32831039d1dab..2d3d09930daad45185454c3db7be1b2dee268e54 100644

--- a/scripts/slave/recipes/findit/chromium/compile.expected/compile_specified_targets.json

+++ b/scripts/slave/recipes/findit/chromium/compile.expected/compile_specified_targets.json

@@ -374,6 +374,53 @@

"cmd": [

"python",

"-u",

+ "[SLAVE_BUILD]/src/tools/mb/mb.py",

+ "gen",

+ "-m",

+ "chromium.linux",

+ "-b",

+ "Linux Builder",

+ "--config-file",

+ "[SLAVE_BUILD]/src/tools/mb/mb_config.pyl",

+ "--goma-dir",

+ "[BUILD]/goma",

+ "//out/Release"

+ ],

+ "cwd": "[SLAVE_BUILD]",

+ "name": "test r1.generate_build_files",

+ "~followup_annotations": [

+ "@@@STEP_NEST_LEVEL@1@@@"

+ ]

+ },

+ {

+ "cmd": [

+ "python",

+ "-u",

+ "RECIPE_MODULE[build::findit]/resources/check_target_existence.py",

+ "--target-build-dir",

+ "[SLAVE_BUILD]/src/out/Release",

+ "--target",

+ "target_name",

+ "--json-output",

+ "/path/to/tmp/json"

+ ],

+ "cwd": "[SLAVE_BUILD]",

+ "name": "test r1.check_targets",

+ "~followup_annotations": [

+ "@@@STEP_NEST_LEVEL@1@@@",

+ "@@@STEP_LOG_LINE@json.output@{@@@",

+ "@@@STEP_LOG_LINE@json.output@ \"found\": [@@@",

+ "@@@STEP_LOG_LINE@json.output@ \"target_name\"@@@",

+ "@@@STEP_LOG_LINE@json.output@ ], @@@",

+ "@@@STEP_LOG_LINE@json.output@ \"not_found\": []@@@",

+ "@@@STEP_LOG_LINE@json.output@}@@@",

+ "@@@STEP_LOG_END@json.output@@@"

+ ]

+ },

+ {

+ "cmd": [

+ "python",

+ "-u",

"[BUILD]/scripts/slave/cleanup_temp.py"

"cwd": "[SLAVE_BUILD]",

@@ -399,7 +446,7 @@

"//out/Release"

"cwd": "[SLAVE_BUILD]",

- "name": "test r1.generate_build_files",

+ "name": "test r1.generate_build_files (2)",

"~followup_annotations": [

"@@@STEP_NEST_LEVEL@1@@@"

]