media/blink/webmediaplayer_impl.h - Issue 1766783003: Expand suspension of idle media players to all platforms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/blink/webmediaplayer_impl.h

Issue 1766783003: Expand suspension of idle media players to all platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@notify_pause

Patch Set: Fixup API comments. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/blink/webmediaplayer_impl.h

diff --git a/media/blink/webmediaplayer_impl.h b/media/blink/webmediaplayer_impl.h

index 0dd640de5d214e025248593fbe75021a7fbf950c..fac56ed155e12fb134fabf55742bf12a0e55f46c 100644

--- a/media/blink/webmediaplayer_impl.h

+++ b/media/blink/webmediaplayer_impl.h

@@ -168,8 +168,9 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl

void exitedFullscreen() override;

// WebMediaPlayerDelegate::Observer implementation.

- void OnHidden(bool must_suspend) override;

+ void OnHidden() override;

void OnShown() override;

+ void OnSuspendRequested(bool must_suspend) override;

void OnPlay() override;

void OnPause() override;

void OnVolumeMultiplierUpdate(double multiplier) override;

@@ -285,6 +286,9 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl

void ReportMemoryUsage();

void FinishMemoryUsageReport(int64_t demuxer_memory_usage);

+ // Indicates if automatic resumption of a suspended playback is allowed.

+ bool IsAutomaticResumeAllowed();

blink::WebLocalFrame* frame_;

// TODO(hclam): get rid of these members and read from the pipeline directly.

« no previous file with comments | « media/blink/webmediaplayer_delegate.h ('k') | media/blink/webmediaplayer_impl.cc » ('j') | no next file with comments »