content/renderer/media/webmediaplayer_ms.h - Issue 1766783003: Expand suspension of idle media players to all platforms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webmediaplayer_ms.h

Issue 1766783003: Expand suspension of idle media players to all platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@notify_pause

Patch Set: Fixup API comments. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/renderer_webmediaplayer_delegate_browsertest.cc ('k') | content/renderer/media/webmediaplayer_ms.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webmediaplayer_ms.h

diff --git a/content/renderer/media/webmediaplayer_ms.h b/content/renderer/media/webmediaplayer_ms.h

index 28e7a1607688e5de3ff3497ffa023172a0927023..8e1379ba44297f6637e764a561d5b9df8d1ce77a 100644

--- a/content/renderer/media/webmediaplayer_ms.h

+++ b/content/renderer/media/webmediaplayer_ms.h

@@ -135,8 +135,9 @@ class CONTENT_EXPORT WebMediaPlayerMS

size_t videoDecodedByteCount() const override;

// WebMediaPlayerDelegate::Observer implementation.

- void OnHidden(bool must_suspend) override;

+ void OnHidden() override;

void OnShown() override;

+ void OnSuspendRequested(bool must_suspend) override;

void OnPlay() override;

void OnPause() override;

void OnVolumeMultiplierUpdate(double multiplier) override;

@@ -223,8 +224,9 @@ class CONTENT_EXPORT WebMediaPlayerMS

double volume_;

double volume_multiplier_;

- // True if the delegate forced a pause during the last OnHidden() call.

- bool paused_on_hidden_;

+ // True if playback should be started upon the next call to OnShown(). Only

+ // used on Android.

+ bool should_play_upon_shown_;

DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerMS);

};