Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: content/renderer/media/webmediaplayer_ms_unittest.cc

Issue 1766783003: Expand suspension of idle media players to all platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@notify_pause
Patch Set: Simplify. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/webmediaplayer_ms_unittest.cc
diff --git a/content/renderer/media/webmediaplayer_ms_unittest.cc b/content/renderer/media/webmediaplayer_ms_unittest.cc
index 271823197797fbb603edc505755c7240be855f44..8c72c32f66e2bcb2dab1de1dc4eef8b059174f3d 100644
--- a/content/renderer/media/webmediaplayer_ms_unittest.cc
+++ b/content/renderer/media/webmediaplayer_ms_unittest.cc
@@ -718,7 +718,7 @@ TEST_F(WebMediaPlayerMSTest, HiddenPlayerTests) {
// A hidden event should not pause the player.
delegate_.set_hidden(true);
- player_.OnHidden(false);
+ player_.OnHidden();
EXPECT_FALSE(player_.paused());
// OnPause() should pause the player.
@@ -735,13 +735,15 @@ TEST_F(WebMediaPlayerMSTest, HiddenPlayerTests) {
player_.play();
EXPECT_FALSE(player_.paused());
- // An OnHidden() with forced suspension should pause playback.
- delegate_.set_hidden(true);
- player_.OnHidden(true);
+ // An OnSuspendRequested() without forced suspension should do nothing.
+ player_.OnSuspendRequested(false);
+ EXPECT_FALSE(player_.paused());
+
+ // An OnSuspendRequested() with forced suspension should pause playback.
+ player_.OnSuspendRequested(true);
EXPECT_TRUE(player_.paused());
// OnShown() should restart after a forced suspension.
- delegate_.set_hidden(false);
player_.OnShown();
EXPECT_FALSE(player_.paused());
EXPECT_CALL(*this, DoSetWebLayer(false));

Powered by Google App Engine
This is Rietveld 408576698