Expand suspension of idle media players to all platforms.

content/renderer/media/android/webmediaplayer_android.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/android/webmediaplayer_android.h"
 
 #include <stddef.h>
 
 #include <limits>
 
@@ skipping 1493 matching lines @@
 
 void WebMediaPlayerAndroid::OnWaitingForDecryptionKey() {
   encrypted_client_->didBlockPlaybackWaitingForKey();
 
   // TODO(jrummell): didResumePlaybackBlockedForKey() should only be called
   // when a key has been successfully added (e.g. OnSessionKeysChange() with
   // |has_additional_usable_key| = true). http://crbug.com/461903
   encrypted_client_->didResumePlaybackBlockedForKey();
 }
 
-void WebMediaPlayerAndroid::OnHidden(bool must_suspend) {
+void WebMediaPlayerAndroid::OnHidden() {
   if (base::CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kDisableMediaSuspend)) {
     return;
   }
 
+  OnSuspendRequested(false);
+}
+
+void WebMediaPlayerAndroid::OnShown() {}
+
+void WebMediaPlayerAndroid::OnSuspendRequested(bool must_suspend) {
   // If we're idle or playing video, pause and release resources; audio only
   // players are allowed to continue playing in the background unless indicated

[sandersd (OOO until July 31), 2016/03/10 19:37:00]

"background" isn't implicitly the correct word here anymore.

[DaleCurtis, 2016/03/10 23:11:36]

Removed.

   // otherwise by the call.
   if (must_suspend || (paused() && playback_completed_) || hasVideo())
     SuspendAndReleaseResources();
 }
 
-void WebMediaPlayerAndroid::OnShown() {}
-
 void WebMediaPlayerAndroid::OnPlay() {
   play();
   client_->playbackStateChanged();
 }
 
 void WebMediaPlayerAndroid::OnPause() {
   pause();
   client_->playbackStateChanged();
 }
 
@@ skipping 122 matching lines @@
     result = PREDICTION_RESULT_PATH_BASED_WAS_BETTER;
   } else if (is_hls_url == is_hls) {
     result = PREDICTION_RESULT_URL_BASED_WAS_BETTER;
   }
   UMA_HISTOGRAM_ENUMERATION(
       "Media.Android.IsHttpLiveStreamingMediaPredictionResult",
       result, PREDICTION_RESULT_MAX);
 }
 
 }  // namespace content