Add a MustNamespace that panics if the namespace wasn't valid

Add a MustNamespace that panics if the namespace wasn't valid

BUG=

Committed: https://github.com/luci/gae/commit/caeb69ff0011940b98cb55069d844bf9f987ac31

[dsansome, 2016-03-04 04:04:06]

dsansome@chromium.org changed reviewers:
+ iannucci@chromium.org

[iannucci, 2016-03-04 06:02:02]

On 2016/03/04 at 04:04:06, dsansome wrote:
> 

What do you think about making it take a context? We don't currently have
precedent for taking Interface directly at the moment.

How hard would it be to add this to the Interface directly (though I realize
that it causes a redundant implementation :/). It might be more consistent as an
API though?

[dsansome, 2016-03-06 23:32:48]

On 2016/03/04 06:02:02, iannucci wrote:
> On 2016/03/04 at 04:04:06, dsansome wrote:
> > 
> 
> What do you think about making it take a context? We don't currently have
> precedent for taking Interface directly at the moment.
> 
> How hard would it be to add this to the Interface directly (though I realize
> that it causes a redundant implementation :/). It might be more consistent as
an
> API though?

I've made it take a context instead.

I did originally add it to Interface, but I worry that it would break any
existing filter implementations that now wouldn't fully implement the interface
any more.  *shrug*  I can do that if you think it's ok.

[iannucci, 2016-03-07 00:28:19]

Yeah I think that's OK. A `go test github.com/luci/gae/...` Will show
everything that needs an update. I think just feature breaker will need
updates

On Sun, Mar 6, 2016, 15:32 <dsansome@chromium.org> wrote:

> On 2016/03/04 06:02:02, iannucci wrote:
> > On 2016/03/04 at 04:04:06, dsansome wrote:
> > >
> >
> > What do you think about making it take a context? We don't currently have
> > precedent for taking Interface directly at the moment.
> >
> > How hard would it be to add this to the Interface directly (though I
> realize
> > that it causes a redundant implementation :/). It might be more
> consistent as
> an
> > API though?
>
> I've made it take a context instead.
>
> I did originally add it to Interface, but I worry that it would break any
> existing filter implementations that now wouldn't fully implement the
> interface
> any more. *shrug* I can do that if you think it's ok.
>
> https://chromiumcodereview.appspot.com/1766593002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dsansome, 2016-03-07 08:11:17]

On 2016/03/07 00:28:19, iannucci wrote:
> Yeah I think that's OK. A `go test github.com/luci/gae/...` Will show
> everything that needs an update. I think just feature breaker will need
> updates
> 
> On Sun, Mar 6, 2016, 15:32 <mailto:dsansome@chromium.org> wrote:
> 
> > On 2016/03/04 06:02:02, iannucci wrote:
> > > On 2016/03/04 at 04:04:06, dsansome wrote:
> > > >
> > >
> > > What do you think about making it take a context? We don't currently have
> > > precedent for taking Interface directly at the moment.
> > >
> > > How hard would it be to add this to the Interface directly (though I
> > realize
> > > that it causes a redundant implementation :/). It might be more
> > consistent as
> > an
> > > API though?
> >
> > I've made it take a context instead.
> >
> > I did originally add it to Interface, but I worry that it would break any
> > existing filter implementations that now wouldn't fully implement the
> > interface
> > any more. *shrug* I can do that if you think it's ok.
> >
> > https://chromiumcodereview.appspot.com/1766593002/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

Done!

[iannucci, 2016-03-07 08:36:35]

lgtm! thanks :)

[dsansome, 2016-03-08 02:46:59]

The CQ bit was checked by dsansome@chromium.org

[commit-bot: I haz the power, 2016-03-08 02:47:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1766593002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1766593002/40001

[commit-bot: I haz the power, 2016-03-08 02:52:00]

Description was changed from

==========
Add a MustNamespace that panics if the namespace wasn't valid

BUG=
==========

to

==========
Add a MustNamespace that panics if the namespace wasn't valid

BUG=

Committed:
https://github.com/luci/gae/commit/caeb69ff0011940b98cb55069d844bf9f987ac31
==========

[commit-bot: I haz the power, 2016-03-08 02:52:01]

Committed patchset #3 (id:40001) as
https://github.com/luci/gae/commit/caeb69ff0011940b98cb55069d844bf9f987ac31