Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 17654007: Don't override system malloc when built with LeakSanitizer. (Closed)

Created:
7 years, 6 months ago by earthdok
Modified:
7 years, 6 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Don't override system malloc when built with LeakSanitizer. Since LeakSanitizer intercepts malloc, we must disable Chromium's malloc override, just like we do with ASan/MSan/TSan. BUG=none R=mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208490

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/process_util_linux.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
earthdok
please review this small change
7 years, 6 months ago (2013-06-25 13:45:38 UTC) #1
Mark Mentovai
LGTM
7 years, 6 months ago (2013-06-25 13:47:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/17654007/1
7 years, 6 months ago (2013-06-25 13:48:21 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-25 15:19:25 UTC) #4
Message was sent while issue was closed.
Change committed as 208490

Powered by Google App Engine
This is Rietveld 408576698