Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1015)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: testing/test_env.py

Issue 17648002: testing/test_env.py: don't silently disable the sandbox (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/test_env.py
diff --git a/testing/test_env.py b/testing/test_env.py
index feca6094d31068bca4b2e277fb9970233f152c71..a65b34b52157045a817f054914c2b73609c2c381 100755
--- a/testing/test_env.py
+++ b/testing/test_env.py
@@ -44,9 +44,11 @@ def enable_sandbox_if_required(env, verbose=False):
env[CHROME_SANDBOX_ENV] = chrome_sandbox_path
else:
if verbose:
- print 'Disabling sandbox. Setting environment variable:'
- print ' %s=""' % CHROME_SANDBOX_ENV
- env[CHROME_SANDBOX_ENV] = ''
+ print 'Sandbox not properly installed. Unsetting:'
+ print ' %s' % CHROME_SANDBOX_ENV
+ # The variable should be removed from the environment, making
+ # the variable empty silently disables the sandbox.
+ env.pop(CHROME_SANDBOX_ENV)
def fix_python_path(cmd):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698