Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: Tools/Scripts/webkitpy/common/checkout/checkout_mock.py

Issue 17639006: Remove committer list, bugzilla, watchlist code and transitive closure of stuff. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: merge on top of thakis' change in r153020 Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/Scripts/webkitpy/common/checkout/checkout_mock.py
diff --git a/Tools/Scripts/webkitpy/common/checkout/checkout_mock.py b/Tools/Scripts/webkitpy/common/checkout/checkout_mock.py
index 6b2ac1140fd093f51d599844c27bb54cced5879d..ca76d57393cfe68b22313b75cc7f5d86152fef52 100644
--- a/Tools/Scripts/webkitpy/common/checkout/checkout_mock.py
+++ b/Tools/Scripts/webkitpy/common/checkout/checkout_mock.py
@@ -26,11 +26,6 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-from .commitinfo import CommitInfo
-
-# FIXME: These imports are wrong, we should use a shared MockCommittersList.
-from webkitpy.common.config.committers import CommitterList
-from webkitpy.common.net.bugzilla.bugzilla_mock import _mock_reviewers
from webkitpy.common.system.filesystem_mock import MockFileSystem
@@ -39,52 +34,12 @@ class MockCommitMessage(object):
return "This is a fake commit message that is at least 50 characters."
-committer_list = CommitterList()
-
-mock_revisions = {
- 1: CommitInfo(852, "eric@webkit.org", {
- "bug_id": 50000,
- "author_name": "Adam Barth",
- "author_email": "abarth@webkit.org",
- "author": committer_list.contributor_by_email("abarth@webkit.org"),
- "reviewer_text": "Darin Adler",
- "reviewer": committer_list.committer_by_name("Darin Adler"),
- "changed_files": [
- "path/to/file",
- "another/file",
- ],
- }),
- 3001: CommitInfo(3001, "tomz@codeaurora.org", {
- "bug_id": 50004,
- "author_name": "Tom Zakrajsek",
- "author_email": "tomz@codeaurora.org",
- "author": committer_list.contributor_by_email("tomz@codeaurora.org"),
- "reviewer_text": "Darin Adler",
- "reviewer": committer_list.committer_by_name("Darin Adler"),
- "changed_files": [
- "path/to/file",
- "another/file",
- ],
- })
-}
-
class MockCheckout(object):
def __init__(self):
# FIXME: It's unclear if a MockCheckout is very useful. A normal Checkout
# with a MockSCM/MockFileSystem/MockExecutive is probably better.
self._filesystem = MockFileSystem()
- def commit_info_for_revision(self, svn_revision):
- # There are legacy tests that all expected these revision numbers to map
- # to the same commit description (now mock_revisions[1])
- if svn_revision in [32, 123, 852, 853, 854, 1234, 21654, 21655, 21656]:
- return mock_revisions[1]
-
- if svn_revision in mock_revisions:
- return mock_revisions[svn_revision]
-
- # any "unrecognized" svn_revision will return None.
-
def is_path_to_changelog(self, path):
return self._filesystem.basename(path) == "ChangeLog"
« no previous file with comments | « Tools/Scripts/webkitpy/common/checkout/checkout.py ('k') | Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698