chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutTab.java - Issue 1763713003: Fix accessibility order of Android tabstrip

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutTab.java

Issue 1763713003: Fix accessibility order of Android tabstrip (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased and fixed Java and GN Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutTab.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutTab.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutTab.java

index 49d2f6bbc82314fc5dd590ac2d38fe310bea4b08..13679ff7cc59bea4d33c7e0fe2b55724b1bbe0d0 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutTab.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutTab.java

@@ -123,8 +123,8 @@ public class StripLayoutTab

* @param views A List to populate with virtual views.

public void getVirtualViews(List<VirtualView> views) {

- if (mShowingCloseButton) views.add(mCloseButton);

views.add(this);

+ if (mShowingCloseButton) views.add(mCloseButton);

}

/**