Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Unified Diff: scripts/slave/recipes/run_presubmit.py

Issue 17635005: Make blink_trybot recipe work on windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Fix presubmit + move polyfill (retry) Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/run_presubmit.py
diff --git a/scripts/slave/recipes/run_presubmit.py b/scripts/slave/recipes/run_presubmit.py
index 270a36d49a1bd23ecff46aebb8b9c6a5e27f42c1..e90db09169111de69c55268f40f22eb896d626a9 100644
--- a/scripts/slave/recipes/run_presubmit.py
+++ b/scripts/slave/recipes/run_presubmit.py
@@ -2,7 +2,14 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-DEPS = ['properties', 'gclient', 'git', 'rietveld', 'step', 'path']
+DEPS = [
+ 'gclient',
+ 'git',
+ 'path',
+ 'properties',
+ 'rietveld',
+ 'step',
+]
def GenSteps(api):
root = api.rietveld.calculate_issue_root()
@@ -18,12 +25,11 @@ def GenSteps(api):
spec = api.gclient.c
if spec.solutions[0].url.endswith('.git'):
- seed_steps = ['git config user.email', 'git config user.name',
- 'git clean']
- yield api.git.command('config', 'user.email', 'commit-bot@chromium.org',
- seed_steps=seed_steps)
- yield api.git.command('config', 'user.name', 'The Commit Bot')
- yield api.git.command('clean', '-xfq')
+ yield (
+ api.git.command('config', 'user.email', 'commit-bot@chromium.org'),
+ api.git.command('config', 'user.name', 'The Commit Bot'),
+ api.git.command('clean', '-xfq')
+ )
yield api.rietveld.apply_issue(root)

Powered by Google App Engine
This is Rietveld 408576698