Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17627005: mac: Remove unused includes of scoped_nsobject.h. (Closed)

Created:
7 years, 6 months ago by Nico
Modified:
7 years, 6 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, asanka, aboxhall+watch_chromium.org, sadrul, yusukes+watch_chromium.org, ahutter, yoshiki+watch_chromium.org, dcheng, dmazzoni+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, ben+watch_chromium.org, benquan, jam, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, dtseng+watch_chromium.org, penghuang+watch_chromium.org, yuzo+watch_chromium.org, Raman Kakilate, ctguil+watch_chromium.org, rouslan+autofillwatch_chromium.org, zork+watch_chromium.org, hashimoto+watch_chromium.org, tfarina, davidbarr+watch_chromium.org, benjhayden+dwatch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, James Su
Visibility:
Public.

Description

mac: Remove unused includes of scoped_nsobject.h. Manual follow-up to mechanical https://codereview.chromium.org/17593006/ BUG=251957 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208410

Patch Set 1 #

Patch Set 2 : builds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -63 lines) Patch
M ash/test/test_suite_init.mm View 1 chunk +0 lines, -1 line 0 comments Download
M base/mac/scoped_sending_event.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_browser_application_mac.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/importer/safari_importer.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ssl/ssl_add_cert_handler_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript_test.mm View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_all_tabs_controller_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.h View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window_unittest.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser/edit_search_engine_cocoa_controller_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/certificate_viewer_mac.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/chrome_event_processing_window.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/chrome_event_processing_window_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/clickhold_button_cell.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/confirm_bubble_controller_unittest.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/confirm_quit_panel_controller_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_mac.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_shelf_view.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/draggable_button_mixin.mm View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_action_context_menu.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_popup_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/framed_browser_window.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_window_unittest.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/hover_close_button.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/hung_renderer_controller_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/info_bubble_view.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/menu_button.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/notifications/balloon_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/notifications/balloon_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/notifications/balloon_view.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/notifications/message_center_tray_bridge_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profile_menu_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profile_menu_controller.mm View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/render_view_context_menu_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_audio_indicator_view_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_audio_indicator_view_mac_unittest.mm View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/throbber_view.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/throbber_view.mm View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/task_manager_mac_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/validation_message_bubble_controller_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/web_applications/web_app_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/mac/objc_method_swizzle.mm View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/text_input_client_message_filter.mm View 1 chunk +0 lines, -1 line 0 comments Download
M net/base/platform_mime_util_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/cocoa/hover_button.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/common/cursors/webcursor_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
7 years, 6 months ago (2013-06-25 00:10:30 UTC) #1
Mark Mentovai
LGTM
7 years, 6 months ago (2013-06-25 02:21:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/17627005/3001
7 years, 6 months ago (2013-06-25 02:24:35 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-25 04:43:01 UTC) #4
Message was sent while issue was closed. 
Change committed as 208410

Powered by Google App Engine
This is Rietveld 408576698