Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 17617004: Fix MIDI code for 64 bit build. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Fix MIDI code for 64 bit build. BUG=163795 TEST=builds everywhere Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208519

Patch Set 1 #

Patch Set 2 : fix 32? #

Patch Set 3 : fix 32? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M media/midi/midi_manager_mac.cc View 1 6 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Avi (use Gerrit)
7 years, 6 months ago (2013-06-24 22:39:30 UTC) #1
Chris Rogers
+scherkus for OWNERS lgtm
7 years, 6 months ago (2013-06-24 22:46:35 UTC) #2
scherkus (not reviewing)
lgtm doesn't C++11 have a solution for this haha
7 years, 6 months ago (2013-06-24 23:18:42 UTC) #3
Avi (use Gerrit)
Mark, can you think of a way to not have to #ifdef here? The midi ...
7 years, 6 months ago (2013-06-25 13:58:46 UTC) #4
Mark Mentovai
You could write your own cast or conversion function, which would at least tuck the ...
7 years, 6 months ago (2013-06-25 14:08:07 UTC) #5
Avi (use Gerrit)
On 2013/06/25 14:08:07, Mark Mentovai wrote: > You could write your own cast or conversion ...
7 years, 6 months ago (2013-06-25 14:37:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/17617004/6002
7 years, 6 months ago (2013-06-25 14:38:09 UTC) #7
Mark Mentovai
Just memcpy, then.
7 years, 6 months ago (2013-06-25 14:46:43 UTC) #8
commit-bot: I haz the power
7 years, 6 months ago (2013-06-25 17:40:56 UTC) #9
Message was sent while issue was closed.
Change committed as 208519

Powered by Google App Engine
This is Rietveld 408576698