media: Handle "encrypted" event in pipeline_integration_fuzzertest.

media/test/pipeline_integration_test_base.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/test/pipeline_integration_test_base.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/memory/scoped_vector.h"
@@ skipping 57 matching lines @@
 
 void PipelineIntegrationTestBase::OnStatusCallback(PipelineStatus status) {
   pipeline_status_ = status;
   message_loop_.PostTask(FROM_HERE, base::MessageLoop::QuitWhenIdleClosure());
 }
 
 void PipelineIntegrationTestBase::DemuxerEncryptedMediaInitDataCB(
     EmeInitDataType type,
     const std::vector<uint8_t>& init_data) {
   DCHECK(!init_data.empty());
-  CHECK(!encrypted_media_init_data_cb_.is_null());
+  if (encrypted_media_init_data_cb_.is_null()) {

[ddorwin, 2016/03/02 21:42:12]

Would ASSERT/EXPECT_FALSE() be better? Then the test would fail but not crash?

[xhwang, 2016/03/02 23:22:40]

PipelineIntegrationTestBase is used by PipelineIntegrationTest,
FFmpegRegressionTest and the new pipeline_integration_fuzzertest. We only
support EME in PipelineIntegrationTest by supplying a FakeEncryptedMedia to
handle EME events. Also we set set_encrypted_media_init_data_cb explicit in
those tests:

https://code.google.com/p/chromium/codesearch#chromium/src/media/test/pipelin...

ASSERT_FALSE will only abort the current function. We still need to post
QuitWhenIdleClosure() to be able to abort the test. Otherwise the test will
abort.

Setting pipeline_status_ on line 81 would finally trigger the test to fail.

+    // TODO(xhwang): Support encrypted media in PipelineIntegrationTestBase.
+    DLOG(WARNING) << "Encryted media not supported.";

[ddorwin, 2016/03/02 21:42:12]

Encry*p*ted

Supported by the test? "Test does not implement support for EME"? "Test does not
expect content to be encrypted"?

+    pipeline_status_ = PIPELINE_ERROR_INITIALIZATION_FAILED;
+    message_loop_.PostTask(FROM_HERE, base::MessageLoop::QuitWhenIdleClosure());

[DaleCurtis, 2016/03/03 00:17:59]

Oy, I forgot we use this in this file, we should convert this class to use
RunLoops since this isn't guaranteed to quit in some cases :)

[xhwang, 2016/03/03 00:38:47]

sgtm. In a different CL though :)

+    return;
+  }
   encrypted_media_init_data_cb_.Run(type, init_data);
 }
 
 void PipelineIntegrationTestBase::OnEnded() {
   DCHECK(!ended_);
   ended_ = true;
   pipeline_status_ = PIPELINE_OK;
   message_loop_.PostTask(FROM_HERE, base::MessageLoop::QuitWhenIdleClosure());
 }
 
@@ skipping 284 matching lines @@
   DCHECK(clockless_playback_);
   return clockless_audio_sink_->render_time();
 }
 
 base::TimeTicks DummyTickClock::NowTicks() {
   now_ += base::TimeDelta::FromSeconds(60);
   return now_;
 }
 
 }  // namespace media