Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 17616008: Android: adds an option to print all sharded steps. (Closed)

Created:
7 years, 6 months ago by bulach
Modified:
7 years, 5 months ago
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Android: adds an option to print all sharded steps. This is necessary to decouple buildbots and the app repository. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209681

Patch Set 1 #

Total comments: 2

Patch Set 2 : ret code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M build/android/bb_run_sharded_steps.py View 1 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bulach
ptal, this is the one that "cat" all the results..
7 years, 6 months ago (2013-06-25 00:14:44 UTC) #1
Primiano Tucci (use gerrit)
On 2013/06/25 00:14:44, bulach wrote: > ptal, this is the one that "cat" all the ...
7 years, 6 months ago (2013-06-25 00:34:32 UTC) #2
bulach
that's right, one json to rule them all. :)
7 years, 6 months ago (2013-06-25 01:07:48 UTC) #3
iannucci
lgtm https://codereview.chromium.org/17616008/diff/1/build/android/bb_run_sharded_steps.py File build/android/bb_run_sharded_steps.py (right): https://codereview.chromium.org/17616008/diff/1/build/android/bb_run_sharded_steps.py#newcode161 build/android/bb_run_sharded_steps.py:161: ret += _PrintStepOutput(step_name) what's the meaning of adding ...
7 years, 6 months ago (2013-06-25 02:16:33 UTC) #4
bulach
thanks both! landing this, ptal at the other side of this patch ;) https://codereview.chromium.org/17616008/diff/1/build/android/bb_run_sharded_steps.py File ...
7 years, 5 months ago (2013-06-28 01:54:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/17616008/7001
7 years, 5 months ago (2013-07-02 09:54:42 UTC) #6
commit-bot: I haz the power
7 years, 5 months ago (2013-07-02 12:14:40 UTC) #7
Message was sent while issue was closed.
Change committed as 209681

Powered by Google App Engine
This is Rietveld 408576698