Add "PRIVATE" to the enum names of some private Pepper networking APIs:

Add "PRIVATE" to the enum names of some private Pepper networking APIs:

- ppb_net_address_private.idl
- ppb_host_resolver_private.idl
- ppb_tcp_socket_private.idl
- ppb_udp_socket_private.idl

Currently, we have very similar enum names in the private and public
Pepper networking APIs (for example, PP_NETADDRESSFAMILY_IPV4
and PP_NETADDRESS_FAMILY_IPV4). The purpose of this CL is to make the
distinction more clear.

This CL doesn't break existing plugins compiled with old private networking enums (without "PRIVATE" in the names). They will still run on newer versions of Chrome.

The only consequence is that they will get compile errors when they compile with new SDK (with new enum names). But the errors should be very straightforward to fix.


BUG=253583
TEST=None
R=bbudge@chromium.org, tsepez@chromium.org, wez@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208291

[yzshen1, 2013-06-24 18:38:17]

Hi, Bill and Tom.

Would you please take a look? Thanks!

Bill: everything
One thing is that I didn't "append" PRIVATE, instead I tried to "insert" it to
match the enum type names.
For example I used "PP_NETADDRESSFAMILY_PRIVATE_IPV4" instead of
"PP_NETADDRESSFAMILY_IPV4".

Tom: please review ppapi_messages.h
This is just pure renaming and it should be safe.

Thanks!

[Wez, 2013-06-24 18:40:25]

remoting/ LGTM

[yzshen1, 2013-06-24 18:42:08]

On Jun 24, 2013 11:38 AM, <yzshen@chromium.org> wrote:
>
> Reviewers: bbudge1, Tom Sepez,
>
> Message:
> Hi, Bill and Tom.
>
> Would you please take a look? Thanks!
>
> Bill: everything
> One thing is that I didn't "append" PRIVATE, instead I tried to "insert"
it to
> match the enum type names.
> For example I used "PP_NETADDRESSFAMILY_PRIVATE_IPV4" instead of
> "PP_NETADDRESSFAMILY_IPV4".

Correction:
For example I used "PP_NETADDRESSFAMILY_PRIVATE_IPV4" instead of
"PP_NETADDRESSFAMILY_IPV4_PRIVATE".

>
> Tom: please review ppapi_messages.h
> This is just pure renaming and it should be safe.
>
> Thanks!
>
> Description:
> Add "PRIVATE" to the enum names of some private Pepper networking APIs:
>
> - ppb_net_address_private.idl
> - ppb_host_resolver_private.idl
> - ppb_tcp_socket_private.idl
> - ppb_udp_socket_private.idl
>
> Currently, we have very similar enum names in the private and public
> Pepper networking APIs (for example, PP_NETADDRESSFAMILY_IPV4
> and PP_NETADDRESS_FAMILY_IPV4). The purpose of this CL is to make the
> distiction more clear.
>
> BUG=253583
> TEST=None
>
> Please review this at https://codereview.chromium.org/17615004/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>   M
content/browser/renderer_host/pepper/pepper_host_resolver_message_filter.cc
>   M ppapi/api/private/ppb_host_resolver_private.idl
>   M ppapi/api/private/ppb_net_address_private.idl
>   M ppapi/api/private/ppb_tcp_socket_private.idl
>   M ppapi/api/private/ppb_udp_socket_private.idl
>   M ppapi/c/private/ppb_host_resolver_private.h
>   M ppapi/c/private/ppb_net_address_private.h
>   M ppapi/c/private/ppb_tcp_socket_private.h
>   M ppapi/c/private/ppb_udp_socket_private.h
>   M ppapi/cpp/private/net_address_private.cc
>   M ppapi/proxy/host_resolver_resource.cc
>   M ppapi/proxy/ppapi_messages.h
>   M ppapi/proxy/udp_socket_private_resource.cc
>   M ppapi/shared_impl/private/net_address_private_impl.cc
>   M ppapi/shared_impl/private/tcp_socket_private_impl.cc
>   M ppapi/tests/test_host_resolver_private.cc
>   M ppapi/tests/test_host_resolver_private_disallowed.cc
>   M ppapi/tests/test_net_address_private.cc
>   M ppapi/tests/test_network_monitor_private.cc
>   M ppapi/tests/test_tcp_socket_private.cc
>   M ppapi/tests/test_udp_socket_private.cc
>   M ppapi/tests/test_utils.cc
>   M remoting/client/plugin/pepper_network_manager.cc
>   M remoting/client/plugin/pepper_port_allocator.cc
>   M remoting/client/plugin/pepper_util.cc
>
>

[bbudge, 2013-06-24 18:48:30]

https://codereview.chromium.org/17615004/diff/1/ppapi/api/private/ppb_host_re...
File ppapi/api/private/ppb_host_resolver_private.idl (right):

https://codereview.chromium.org/17615004/diff/1/ppapi/api/private/ppb_host_re...
ppapi/api/private/ppb_host_resolver_private.idl:24:
PP_HOST_RESOLVER_PRIVATE_FLAGS_CANONNAME = 1 << 0,
Why not change FLAGS to FLAG while you're at it?

[Tom Sepez, 2013-06-24 19:25:37]

lgtm

[yzshen1, 2013-06-24 19:35:00]

Thanks, Bill and James!

https://codereview.chromium.org/17615004/diff/1/ppapi/api/private/ppb_host_re...
File ppapi/api/private/ppb_host_resolver_private.idl (right):

https://codereview.chromium.org/17615004/diff/1/ppapi/api/private/ppb_host_re...
ppapi/api/private/ppb_host_resolver_private.idl:24:
PP_HOST_RESOLVER_PRIVATE_FLAGS_CANONNAME = 1 << 0,
IMHO, we probably don't want to spend time on beautifying/improving the private
APIs. We change the private names mostly for making the public APIs more clear.

If I change FLAGS to FLAG, I will also need to change the enum type name. And
that seems to be a different issue than the one that I would like to solve here.

What do you think?

On 2013/06/24 18:48:30, bbudge1 wrote:
> Why not change FLAGS to FLAG while you're at it?

[yzshen1, 2013-06-24 19:35:18]

On 2013/06/24 19:25:37, Tom Sepez wrote:
> lgtm

Thanks Tom!

[bbudge, 2013-06-24 19:37:36]

LGTM

[commit-bot: I haz the power, 2013-06-24 19:47:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yzshen@chromium.org/17615004/1

[yzshen1, 2013-06-24 23:18:13]

Committed patchset #2 manually as r208291 (presubmit successful).