Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1620)

Side by Side Diff: chrome/browser/process_singleton.h

Issue 17615003: ProcessSingleton now uses base::win::MessageWindow to create a message-only window. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: CR feedback. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/chrome_process_finder_win.cc ('k') | chrome/browser/process_singleton_win.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PROCESS_SINGLETON_H_ 5 #ifndef CHROME_BROWSER_PROCESS_SINGLETON_H_
6 #define CHROME_BROWSER_PROCESS_SINGLETON_H_ 6 #define CHROME_BROWSER_PROCESS_SINGLETON_H_
7 7
8 #include "build/build_config.h" 8 #include "build/build_config.h"
9 9
10 #if defined(OS_WIN) 10 #if defined(OS_WIN)
(...skipping 10 matching lines...) Expand all
21 #include "base/logging.h" 21 #include "base/logging.h"
22 #include "base/memory/ref_counted.h" 22 #include "base/memory/ref_counted.h"
23 #include "base/process.h" 23 #include "base/process.h"
24 #include "base/threading/non_thread_safe.h" 24 #include "base/threading/non_thread_safe.h"
25 #include "ui/gfx/native_widget_types.h" 25 #include "ui/gfx/native_widget_types.h"
26 26
27 #if defined(OS_LINUX) || defined(OS_OPENBSD) 27 #if defined(OS_LINUX) || defined(OS_OPENBSD)
28 #include "base/files/scoped_temp_dir.h" 28 #include "base/files/scoped_temp_dir.h"
29 #endif // defined(OS_LINUX) || defined(OS_OPENBSD) 29 #endif // defined(OS_LINUX) || defined(OS_OPENBSD)
30 30
31 #if defined(OS_WIN)
32 #include "base/win/message_window.h"
33 #endif // defined(OS_WIN)
34
31 class CommandLine; 35 class CommandLine;
32 36
33 // ProcessSingleton ---------------------------------------------------------- 37 // ProcessSingleton ----------------------------------------------------------
34 // 38 //
35 // This class allows different browser processes to communicate with 39 // This class allows different browser processes to communicate with
36 // each other. It is named according to the user data directory, so 40 // each other. It is named according to the user data directory, so
37 // we can be sure that no more than one copy of the application can be 41 // we can be sure that no more than one copy of the application can be
38 // running at once with a given data directory. 42 // running at once with a given data directory.
39 // 43 //
40 // Implementation notes: 44 // Implementation notes:
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 // false is returned, we are not the singleton instance and the caller must 81 // false is returned, we are not the singleton instance and the caller must
78 // exit. 82 // exit.
79 // NOTE: Most callers should generally prefer NotifyOtherProcessOrCreate() to 83 // NOTE: Most callers should generally prefer NotifyOtherProcessOrCreate() to
80 // this method, only callers for whom failure is prefered to notifying another 84 // this method, only callers for whom failure is prefered to notifying another
81 // process should call this directly. 85 // process should call this directly.
82 bool Create(); 86 bool Create();
83 87
84 // Clear any lock state during shutdown. 88 // Clear any lock state during shutdown.
85 void Cleanup(); 89 void Cleanup();
86 90
87 #if defined(OS_WIN)
88 LRESULT WndProc(HWND hwnd, UINT message, WPARAM wparam, LPARAM lparam);
89 #endif
90
91 #if defined(OS_LINUX) || defined(OS_OPENBSD) 91 #if defined(OS_LINUX) || defined(OS_OPENBSD)
92 static void DisablePromptForTesting(); 92 static void DisablePromptForTesting();
93 #endif // defined(OS_LINUX) || defined(OS_OPENBSD) 93 #endif // defined(OS_LINUX) || defined(OS_OPENBSD)
94 94
95 protected: 95 protected:
96 // Notify another process, if available. 96 // Notify another process, if available.
97 // Returns true if another process was found and notified, false if we should 97 // Returns true if another process was found and notified, false if we should
98 // continue with the current process. 98 // continue with the current process.
99 // On Windows, Create() has to be called before this. 99 // On Windows, Create() has to be called before this.
100 NotifyResult NotifyOtherProcess(); 100 NotifyResult NotifyOtherProcess();
(...skipping 15 matching lines...) Expand all
116 private: 116 private:
117 #if !defined(OS_MACOSX) 117 #if !defined(OS_MACOSX)
118 // Timeout for the current browser process to respond. 20 seconds should be 118 // Timeout for the current browser process to respond. 20 seconds should be
119 // enough. It's only used in Windows and Linux implementations. 119 // enough. It's only used in Windows and Linux implementations.
120 static const int kTimeoutInSeconds = 20; 120 static const int kTimeoutInSeconds = 20;
121 #endif 121 #endif
122 122
123 NotificationCallback notification_callback_; // Handler for notifications. 123 NotificationCallback notification_callback_; // Handler for notifications.
124 124
125 #if defined(OS_WIN) 125 #if defined(OS_WIN)
126 // This ugly behemoth handles startup commands sent from another process.
127 LRESULT OnCopyData(HWND hwnd, const COPYDATASTRUCT* cds);
128
129 bool EscapeVirtualization(const base::FilePath& user_data_dir); 126 bool EscapeVirtualization(const base::FilePath& user_data_dir);
130 127
131 HWND remote_window_; // The HWND_MESSAGE of another browser. 128 HWND remote_window_; // The HWND_MESSAGE of another browser.
132 HWND window_; // The HWND_MESSAGE window. 129 base::win::MessageWindow window_; // The message-only window.
133 bool is_virtualized_; // Stuck inside Microsoft Softricity VM environment. 130 bool is_virtualized_; // Stuck inside Microsoft Softricity VM environment.
134 HANDLE lock_file_; 131 HANDLE lock_file_;
135 base::FilePath user_data_dir_; 132 base::FilePath user_data_dir_;
136 #elif defined(OS_LINUX) || defined(OS_OPENBSD) 133 #elif defined(OS_LINUX) || defined(OS_OPENBSD)
137 // Return true if the given pid is one of our child processes. 134 // Return true if the given pid is one of our child processes.
138 // Assumes that the current pid is the root of all pids of the current 135 // Assumes that the current pid is the root of all pids of the current
139 // instance. 136 // instance.
140 bool IsSameChromeInstance(pid_t pid); 137 bool IsSameChromeInstance(pid_t pid);
141 138
142 // Extract the process's pid from a symbol link path and if it is on 139 // Extract the process's pid from a symbol link path and if it is on
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
179 // File descriptor associated with the lockfile, valid between 176 // File descriptor associated with the lockfile, valid between
180 // |Create()| and |Cleanup()|. Two instances cannot have a lock on 177 // |Create()| and |Cleanup()|. Two instances cannot have a lock on
181 // the same file at the same time. 178 // the same file at the same time.
182 int lock_fd_; 179 int lock_fd_;
183 #endif 180 #endif
184 181
185 DISALLOW_COPY_AND_ASSIGN(ProcessSingleton); 182 DISALLOW_COPY_AND_ASSIGN(ProcessSingleton);
186 }; 183 };
187 184
188 #endif // CHROME_BROWSER_PROCESS_SINGLETON_H_ 185 #endif // CHROME_BROWSER_PROCESS_SINGLETON_H_
OLDNEW
« no previous file with comments | « chrome/browser/chrome_process_finder_win.cc ('k') | chrome/browser/process_singleton_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698