Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 17603006: Add printing to the Files.app's gallery. (Closed)

Created:
7 years, 6 months ago by mtomasz
Modified:
7 years, 6 months ago
Reviewers:
hashimoto, hirono
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, rginda+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Add printing to the Files.app's gallery. This patch adds the icon for printing in the slide mode. Also, enabled the shortcut (Ctrl+P) to invoke the dialog. TEST=Open any picture, hit ctrl+p or hit on the button. Printing should be disabled in the mosaic view. BUG=152090 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208692

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments. #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -8 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/css/gallery.css View 1 chunk +18 lines, -2 lines 0 comments Download
M chrome/browser/resources/file_manager/js/photo/gallery.js View 1 5 chunks +30 lines, -5 lines 0 comments Download
M chrome/browser/resources/file_manager/js/photo/slide_mode.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
mtomasz
@hashimoto: PTAL at the file_browser_private_api.cc @hirono: PTAL at the rest. Thanks!
7 years, 6 months ago (2013-06-25 08:07:34 UTC) #1
hashimoto
file_browser_private_api.cc lgtm
7 years, 6 months ago (2013-06-25 10:06:39 UTC) #2
hirono
https://codereview.chromium.org/17603006/diff/1/chrome/browser/resources/file_manager/js/photo/gallery.js File chrome/browser/resources/file_manager/js/photo/gallery.js (right): https://codereview.chromium.org/17603006/diff/1/chrome/browser/resources/file_manager/js/photo/gallery.js#newcode511 chrome/browser/resources/file_manager/js/photo/gallery.js:511: mode == this.modeButton_ ? this.mosaicMode_ : this.slideMode_; Is this.modeButton_ ...
7 years, 6 months ago (2013-06-26 03:43:44 UTC) #3
mtomasz
https://codereview.chromium.org/17603006/diff/1/chrome/browser/resources/file_manager/js/photo/gallery.js File chrome/browser/resources/file_manager/js/photo/gallery.js (right): https://codereview.chromium.org/17603006/diff/1/chrome/browser/resources/file_manager/js/photo/gallery.js#newcode511 chrome/browser/resources/file_manager/js/photo/gallery.js:511: mode == this.modeButton_ ? this.mosaicMode_ : this.slideMode_; On 2013/06/26 ...
7 years, 6 months ago (2013-06-26 05:52:31 UTC) #4
hirono
lgtm! Thank you for filing the bug!
7 years, 6 months ago (2013-06-26 05:55:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/17603006/8001
7 years, 6 months ago (2013-06-26 05:57:56 UTC) #6
commit-bot: I haz the power
Can't process patch for file chrome/browser/resources/file_manager/images/gallery/2x/icon_print_selected.png. Binary file support is temporarilly disabled due to a ...
7 years, 6 months ago (2013-06-26 05:57:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/17603006/18001
7 years, 6 months ago (2013-06-26 06:19:50 UTC) #8
commit-bot: I haz the power
7 years, 6 months ago (2013-06-26 12:48:02 UTC) #9
Message was sent while issue was closed.
Change committed as 208692

Powered by Google App Engine
This is Rietveld 408576698