Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 17603004: Remove dead code in DOMWindow. (Closed)

Created:
7 years, 6 months ago by dcheng
Modified:
7 years, 6 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, eae+blinkwatch
Visibility:
Public.

Description

Remove dead code in DOMWindow. git bisect archaeology indicates that this was only used by the Mac port in WebView.mm, which was removed in r147526. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152989

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -71 lines) Patch
M Source/core/page/DOMWindow.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/page/DOMWindow.cpp View 1 chunk +0 lines, -68 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dcheng
7 years, 6 months ago (2013-06-24 23:18:49 UTC) #1
abarth-chromium
lgtm Great!
7 years, 6 months ago (2013-06-25 04:44:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/17603004/1
7 years, 6 months ago (2013-06-25 04:44:37 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-25 05:46:15 UTC) #4
Message was sent while issue was closed.
Change committed as 152989

Powered by Google App Engine
This is Rietveld 408576698