Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 17601011: Fix InternetAddress.resolve impl and test for Windows. (Closed)

Created:
7 years, 6 months ago by Anders Johnsen
Modified:
7 years, 6 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix InternetAddress.resolve impl and test for Windows. BUG= Committed: https://code.google.com/p/dart/source/detail?r=24396

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M runtime/bin/socket_win.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M tests/standalone/io/internet_address_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
7 years, 6 months ago (2013-06-25 11:40:15 UTC) #1
Anders Johnsen
Committed patchset #1 manually as r24396 (presubmit successful).
7 years, 6 months ago (2013-06-25 11:40:33 UTC) #2
Anders Johnsen
TBR
7 years, 6 months ago (2013-06-25 11:40:59 UTC) #3
Søren Gjesse
7 years, 6 months ago (2013-06-26 14:55:22 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698