chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActivity.java - Issue 1759483002: [Snackbar] Replace popup window with views

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActivity.java

Issue 1759483002: [Snackbar] Replace popup window with views (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/snackbar/LoFiBarPopupController.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActivity.java

index 96f078672d9412bc50744b227eb177dfabc180a2..484c0cf64317c02ba33efae3b8872177bdb549d8 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActivity.java

@@ -7,6 +7,7 @@ package org.chromium.chrome.browser.bookmarks;

import android.content.Intent;

import android.os.Bundle;

import android.text.TextUtils;

+import android.view.ViewGroup;

import android.view.WindowManager;

import org.chromium.chrome.R;

@@ -32,7 +33,7 @@ public class BookmarkActivity extends BookmarkActivityBase implements SnackbarMa

protected void onCreate(Bundle savedInstanceState) {

super.onCreate(savedInstanceState);

getWindow().clearFlags(WindowManager.LayoutParams.FLAG_DRAWS_SYSTEM_BAR_BACKGROUNDS);

- mSnackbarManager = new SnackbarManager(getWindow());

+ mSnackbarManager = new SnackbarManager((ViewGroup) findViewById(android.R.id.content));

mBookmarkManager = new BookmarkManager(this, true);

String url = getIntent().getDataString();

if (TextUtils.isEmpty(url)) url = UrlConstants.BOOKMARKS_URL;